Sure, I can apply your patch in the Debian cpmtools package, since it has been accepted upstream. I try to avoid forks, but gaining quicker access to something that is coming in upstream's next release seems good.
Bdale On August 29, 2024 7:11:12 AM CDT, Jacob Nevins <jacobn+deb...@chiark.greenend.org.uk> wrote: >I wrote: >> So what needs to happen is: >> >> - libdsk's dg_opusgeom() needs to get more discriminating, at the >> very least, so it doesn't misfire on disc images like yours (but I >> don't know enough about the Opus Discovery to speculate how); > >This has happened; John Elliott has released libdsk 1.5.20, with a fix >that's sufficient to solve this problem. >I've poked Debian bug #1027767 to note that an upgrade to Debian's >version of libdsk would fix this bug. > >> - maybe libdsk could usefully learn about TIM 011 boot sectors >> specifically [...] > >(This hasn't happened, and doesn't need to.) > >> - probably cpmtools' device_libdsk.c:Device_setGeometry() needs to be >> more thorough about sanitising DSK_GEOMETRY if it decides the >> autodetected geometry was garbage. > >I've sent a patch for this to cpmtools upstream, which has been accepted >and will be in the next upstream release, whenever that is. >That patch alone is also sufficient to solve this problem. > >Dunno what you want to do in Debian. >Since a fix in either libdsk or cpmtools would be sufficient to fix this >bug, we could do the thing of assigning the bug to both packages. >If you don't want to wait for either the Debian libdsk maintainer or >cpmtools upstream, I could send you my cpmtools patch to apply in >Debian?
