Hi Javier! Javier Fernández-Sanguino Peña [2005-01-19 11:40 +0100]: > It would be best if instead of > > tmp_tagfile=`mktemp -t tcltagXXXXXX` || exit 1 > > you had used > > tmp_tagfile=`mktemp -t tcltagXXXXXX` || { echo "$0: error creating the > temporary file" >&2; exit 1 ;} > > IMHO
There is no need for this. mktemp generates an error message on its own, so this would only write two messages. > In any case, no use in arguing this when there is so many things to work on > (and so many similar security bugs to report) Right, I just wanted to point out above mktemp behavior, since this seems to be a common misconception. Thanks for your great work and have a nice day! Martin -- Martin Pitt http://www.piware.de Ubuntu Developer http://www.ubuntulinux.org Debian GNU/Linux Developer http://www.debian.org
signature.asc
Description: Digital signature