Package: svn-buildpackage
Version: 0.5.11
Severity: normal
Tags: patch

While building a package I noticied one of the files had disapeared. I tracked
down the problem to the parsing of the 'svn status -v'. The problem is that
the regular expresion will only return the last part of the filename, if the
filename has a space.

I modified that regular expresion and everything worked ok. I'm sending you a
patch with the re I changed, but I think this new re can still have problems.
The real problem is that filenames can be anything and basing the re matching
logic to the end of the line is not a good idea.

K.


-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.9-99-kadath
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages svn-buildpackage depends on:
ii  devscripts                    2.8.10     Scripts to make the life of a Debi
ii  perl                          5.8.4-5    Larry Wall's Practical Extraction 
ii  subversion                    1.1.1-2    Advanced version control system (a
ii  subversion-tools              1.1.1-2    Assorted tools related to Subversi

-- no debconf information

-- 
        .''`.         | Lucas Wall <[EMAIL PROTECTED]>
       : :' :         | Buenos Aires, Argentina
       `. `'          | http://www.kadath.com.ar
         `-           | PGP: 1024D/84FB46D6
   Debian Developer   |      5D25 528A 83AB 489B 356A
http://www.debian.org |      4087 BC9B 4733 84FB 46D6
--- svn-buildpackage.orig       2005-01-19 04:26:59.000000000 -0300
+++ svn-buildpackage    2005-01-19 12:55:49.000000000 -0300
@@ -269,7 +269,7 @@
 print STDERR "Creating file list...\n" if $opt_verbose;
 open($stat, "svn status -v |");
 while(<$stat>) {
-   if(/^[^\?].*\s+(\S+)\n/) {
+   if(/^[^\?].*\d+\s+\d+\s+\S+\s+(.*)\n/) {
       $_=$1;
       if ($_ ne ".") {
          if(-d $_) {

Attachment: signature.asc
Description: Digital signature

Reply via email to