On Sat, 2005-01-22 at 15:12 +0100, Marc Haber wrote:
> On Sat, Jan 22, 2005 at 12:43:45PM +0100, Gergely Nagy wrote:
> > The only concern I have is the file to flag debian-only status. It might
> > be more useful if it would be debian/patches/00dpep-options (or
> > something similar), where one could tweak a selected set of
> > dpatch-edit-patch options.
> 
> If the presence of that file doesn't confuse other programs from the
> dpatch suite, it is of course the best option.

It shouldn't. If it does, the tool which got confused needs to be fixed.

> > Not instructions on how to find the
> > orig.tar.gz though - that's a job of the origtargz finder script, and
> > debian/watch should be good enough for that. If not, then I think that
> > whoever is building the package should know how to get ahold of the
> > tarball and place it in a place where it can be found.
> 
> When we have a config file, that file should have an option to
> directly point the origtargz finder to the direct path. I am currently
> debating with the svn-buildpackage maintainer to have a user-specific
> config file in the home directory containing a list of package names
> and locations for .orig.tar.gz files. Maybe dpep could support that
> file as well.

I do NOT want to have direct, local paths in the file. That will break
dpatch-edit-patch the first time someone has a different directory
setup. 

Say, the file has
ORIGTARGZ_LOCATION="/home/jrandomdeveloper/origs/foo_1.0.orig.tar.gz";
this will break as soon as someone else than jrandomdeveloper wants to
use dpatch-edit-patch. If it is only a hint, and other locations are
searched as well, then I do not thing it is worth the effort at all.

For the same reason I do not want dpep to support svn-buildpackage's
configfile (if there will be such a thing): that is not our territory.
Instead of parsing that file, a hook that copies or symlinks the
orig.tar.gz to a location where dpep can find it would be MUCH better (a
hook in svn-buildpackage, that is).
With cvs-buildpackage, one can do that, works fine, and does not need
hacks in dpep.

(And that is why I consider backuping out the .svn/deb-layout thing too,
now that I thought some more about the issue)

-- 
Gergely Nagy



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to