Package: dact
Version: 0.8.42-3
Severity: important
Tags: patch

Dear Maintainer,

The CPPFLAGS hardening flags are missing because they are not set
in debian/rules.

The following patch fixes the issue.

diff -Nru dact-0.8.42/debian/rules dact-0.8.42/debian/rules
--- dact-0.8.42/debian/rules    2012-02-11 10:10:37.000000000 +0100
+++ dact-0.8.42/debian/rules    2012-03-22 16:50:54.000000000 +0100
@@ -35,6 +35,7 @@
        cp -vf /usr/share/misc/config.guess .
        autoconf
        CFLAGS="$(CFLAGS)" \
+       CPPFLAGS="$(CPPFLAGS)" \
        LDFLAGS="$(LDFLAGS)" \
        ./configure \
                --disable-modules \

To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log (hardening-check doesn't catch everything):

    $ hardening-check /usr/bin/dact /usr/lib/dact/libdact.so
    /usr/bin/dact:
     Position Independent Executable: no, normal executable!
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!
    /usr/lib/dact/libdact.so:
     Position Independent Executable: no, regular shared library (ignored)
     Stack protected: yes
     Fortify Source functions: yes (some protected functions found)
     Read-only relocations: yes
     Immediate binding: no not found!

(Position Independent Executable and Immediate binding is not
enabled by default.)

Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Attachment: signature.asc
Description: Digital signature

Reply via email to