Hi Colin, On 03.04.2012 01:08, Colin Watson wrote: > severity 665550 serious > tags 665550 patch > user ubuntu-de...@lists.ubuntu.com > usertags 665550 ubuntu-patch precise > thanks > > On Sat, Mar 24, 2012 at 08:04:45PM +0100, bi...@debian.org wrote: >> Starting with glib 2.32 it is now mandatory to include glib.h instead >> of individual headers [1], or the compiler will generate an error. > > Now that glib 2.32 is in sid, gtk-sharp2 FTBFS, so upgrading severity. > It also needs to be corrected for the threading changes in 2.32. > > Here's the diff from 2.12.10-2ubuntu2 to 2.12.10-2ubuntu4 in Ubuntu, > which I think is basically what you want here:
Thanks for forwarding the patch! > > [ Christopher James Halse Rogers ] > * debian/patches/04_fix_glib_2.31_threading.dpatch: > + GLib 2.31 always has threading support, always initialises it, and has > dropped some deprecated functions. Update glibsharpglue and > Thread.cs to match. Fixes FTBFS (LP: #911125, LP: #935518) > * debian/control: > + Add versioned dependency on glib > 2.31 to libglib2.0-cil, as we depend > on the threading behaviour of those GLibs. > +Depends: libglib2.0-0 (>= 2.31), ${shlibs:Depends}, ${misc:Depends}, > ${cli:Depends} Hard-coding the libglib2.0-0 dependency is ugly. I suggest bumping the build-dependency on libglib2.0-dev to (>= 2.31) instead. This will ensure to generate a proper versioned dependency via shlibs:Depends. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature