tags 665791 + patch
thanks

On Tue, Apr 03, 2012 at 12:39:16PM +0300, Antti-Juhani Kaijanaho wrote:
> Silly me - it has to be 8bb27 as it's the only commit after my yesterday 
> tests,
> and in my tests yesterday it wasn't fixed in upstream master.

Confirmed.  I just tested this by importing that patch into the
network-manager/0.9.4.0-2 source and building and installing the resulting
libnm-glib4; the bug is gone.


commit 8bb278944496102a4afad46b53e1e8279425aaac
Author: Jiří Klimeš <jkli...@redhat.com>
Date:   Mon Apr 2 16:37:55 2012 +0200

    libnm-glib: initialize GError, else invalid free() crash can occur (rh 
#809123)

diff --git a/libnm-glib/nm-remote-settings.c b/libnm-glib/nm-remote-settings.c
index 9a81a8d..68aaeb4 100644
--- a/libnm-glib/nm-remote-settings.c
+++ b/libnm-glib/nm-remote-settings.c
@@ -109,7 +109,7 @@ static void
 _nm_remote_settings_ensure_inited (NMRemoteSettings *self)
 {
        NMRemoteSettingsPrivate *priv = NM_REMOTE_SETTINGS_GET_PRIVATE (self);
-       GError *error;
+       GError *error = NULL;
 
        if (!priv->inited) {
                if (!g_initable_init (G_INITABLE (self), NULL, &error)) {


-- 
Antti-Juhani Kaijanaho, Jyväskylä, Finland
http://antti-juhani.kaijanaho.fi/newblog/

Attachment: signature.asc
Description: Digital signature

Reply via email to