On Thu, Mar 29, 2012 at 07:33:19PM +0100, Wookey wrote: > diff -urN origs/insserv-1.14.0/debian/patches/130_crossbuild_fixes.patch > patched/insserv-1.14.0/debian/patches/130_crossbuild_fixes.patch > +Index: insserv-1.14.0/Makefile > +=================================================================== > +--- insserv-1.14.0.orig/Makefile 2012-03-29 19:02:05.000000000 +0100 > ++++ insserv-1.14.0/Makefile 2012-03-29 19:03:01.000000000 +0100 > +@@ -38,7 +38,6 @@ > + LDFLAGS += -Wl,--as-needed > + LIBS += -lrpm > + endif > +- CC = gcc > + RM = rm -f > + MKDIR = mkdir -p > + RMDIR = rm -rf
This chunk is unnecessary. You can already override make variable assignments on make's command line; variable assignments like this just set defaults and are harmless for your purposes. Since this kind of default is a very common pattern in Makefiles, it would be best to avoid getting into the habit of believing that it needs to be changed to support cross-building. (The rest looks sensible to me, though I'm not a Debian insserv maintainer.) Cheers, -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
