On 10 April 2012 19:00, shawn <[email protected]> wrote: > On Tue, 2012-04-10 at 17:35 +1000, Martin Pool wrote: >> Hi, >> >> As original upstream I'm -0 on this patch. > Just for clarification: you are neutral?
I mean I don't want to merge it without understanding why you think it's necessary. >> <http://lintian.debian.org/maintainer/[email protected]#distcc> >> doesn't show any warnings that are obviously connected with linking >> against gnome. Which ones are you talking about? > > https://buildd.debian.org/~brlink/packages/d/distcc.html > I-shlibs-useless-link > dpkg-shlibdeps: warning: dependency on libgconf-2.so.4 could be avoided > if "debian/distccmon-gnome/usr/bin/distccmon-gnome" were not uselessly > linked against it (they use none of its symbols). > > and a bunch more > > sorry, this isn't lintian, but i did see it from the DPTS page > http://packages.qa.debian.org/d/distcc.html >> >> I haven't touched this in many years, but istr that linking against >> the gnome libraries does give some better behaviour wrt window manager >> or session manager integration. The larger environment may have >> changed since then. Does removing the dependencies really help >> anything much? I suppose it might on xfce-oriented installs. >> > I actually looked at the (very short) source, and it really didn't seem > like it made much of a difference. Alot of these dependancies are > obsolete gnome 2 libraries, and it would be good to not depend on them > as much as possible. Both this, and linking unused libraries, seem like upstream problems that ought to be fixed, not just cut out in Debian. Really, it ought to just be updated to gtk3, since that will both possibly eliminate the gnome dependency <http://live.gnome.org/ProjectRidley> and also move it forward from gtk2, which is also heading for obsolescence. I can understand how you might want to do a smaller patch, but just suppressing a warning doesn't seem like much of a win. >> Also, *ridiculous, *extraneous (though I suppose they're not actually >> going in to the tree.) > They are being linked according to the build log My point was those words were misspelled and it's better not to have misspelled words in the source history. -- Martin -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
