Dean Michael Berris wrote: > Added support for external configuration file defined through -C. > Currently, the supported options in the configuration file are "cpuid=", > "msr=", and "verbose". The default configuration file is set at > /etc/longrun.conf when -C is invoked without an argument.
This is contrary to how almost all unix programs work -- having to specify an option to turn on use of a configuration file is weird. Expected behavior is for a config file to be used if it's present. What's the reason for this weirdness? > -utility is used to control and query LongRun settings on Transmeta > -Crusoe processors. > +utility is used to control and query LongRun settings on Transmeta(tm) > +Crusoe(tm) processors. > +.P > This program requires that the Linux CPUID and MSR devices be compiled > into the kernel (or loaded as kernel modules), that the CPUID character > device be readable, and that the MSR character device be both readable > and writable. > +.P > #define VERSION "0.9" > -#define REVDATE "2001-02-14" > +#define REVDATE "2005-10-1" The above changes seem to have nothing to do with adding the config file. > +#define _GNU_SOURCE > + /* use GNU getline to read the lines and extract pertinent > informationa This makes longrun require glibc to work, which seems undesirable and not really needed since the config file contains very short and simple lines that could be esily read using standard C functions. -- see shy jo
signature.asc
Description: Digital signature
