Package: python-greenlet
Version: 0.3.3-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu quantal ubuntu-patch


Hi,

python-support is largely deprecated now, with the switch over to dh_python2.  
Please could you consider converting.  I have attached a patch, along with some 
other Lintian fixes for your review.

Thanks.

P: python-greenlet source: package-lacks-versioned-build-depends-on-debhelper 7
W: python-greenlet source: debhelper-overrides-need-versioned-build-depends (>= 
7.0.50~)
E: python-greenlet source: 
depends-on-build-essential-package-without-using-version gcc [build-depends: 
gcc]
P: python-greenlet source: unneeded-build-dep-on-quilt

  * debian/{control,rules}:
    - Convert to dh_python2
    - Drop quilt, it's implied with source format quilt (3.0).
  * debian/rules: Special handling of strip is no longer required.
  * debian/control:
    - Drop gcc build depends, it's an essential package.
    - Depend on versioned debhelper (>= 7.0.50~), required for rules overrides.
    - Bumped Standards to 3.9.3 (no changes required).
  * wrap-and-sorted.


Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500, 
'precise'), (100, 'precise-backports')
Architecture: i386 (x86_64)

Kernel: Linux 3.2.0-24-generic (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru python-greenlet-0.3.3/debian/changelog python-greenlet-0.3.3/debian/changelog
diff -Nru python-greenlet-0.3.3/debian/control python-greenlet-0.3.3/debian/control
--- python-greenlet-0.3.3/debian/control	2012-02-11 20:23:44.000000000 +0000
+++ python-greenlet-0.3.3/debian/control	2012-05-17 09:46:42.000000000 +0100
@@ -1,10 +1,14 @@
 Source: python-greenlet
 Priority: extra
-Maintainer: Örjan Persson <ora...@fobie.net>
+Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
+XSBC-Original-Maintainer: Örjan Persson <ora...@fobie.net>
 Uploaders: Andreas Schuldei <andr...@debian.org>
-Build-Depends: debhelper, gcc, python-all-dev, python-all-dbg,
- python-setuptools, python-support, python-sphinx, quilt
-Standards-Version: 3.9.2
+Build-Depends: debhelper (>= 7.0.50~),
+               python-all-dbg,
+               python-all-dev,
+               python-setuptools,
+               python-sphinx
+Standards-Version: 3.9.3
 Section: python
 Homepage: http://pypi.python.org/pypi/greenlet
 Vcs-Browser: http://git.42mm.org/?p=python-greenlet
@@ -13,7 +17,9 @@
 Package: python-greenlet-dbg
 Section: debug
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, python-greenlet (= ${binary:Version})
+Depends: python-greenlet (= ${binary:Version}),
+         ${misc:Depends},
+         ${shlibs:Depends}
 Recommends: python-dbg
 Description: Lightweight in-process concurrent programming - debugging symbols
  The greenlet package is a spin-off of Stackless, a version of CPython that
@@ -30,7 +36,7 @@
 Package: python-greenlet-doc
 Section: doc
 Architecture: all
-Depends: ${shlibs:Depends}, ${misc:Depends}, libjs-jquery, libjs-underscore
+Depends: libjs-jquery, libjs-underscore, ${misc:Depends}, ${shlibs:Depends}
 Suggests: python-greenlet, python-greenlet-dev
 Description: Lightweight in-process concurrent programming - documentation
  The greenlet package is a spin-off of Stackless, a version of CPython that
@@ -46,7 +52,9 @@
 
 Package: python-greenlet-dev
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, python-greenlet (= ${binary:Version})
+Depends: python-greenlet (= ${binary:Version}),
+         ${misc:Depends},
+         ${shlibs:Depends}
 Description: Lightweight in-process concurrent programming - development files
  The greenlet package is a spin-off of Stackless, a version of CPython that
  supports micro-threads called "tasklets". Tasklets run pseudo-concurrently
@@ -61,9 +69,9 @@
 
 Package: python-greenlet
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}
+Depends: ${misc:Depends}, ${python:Depends}, ${shlibs:Depends}
 Conflicts: python-codespeak-lib (<< 1.0)
-Suggests: python-greenlet-doc, python-greenlet-dev, python-greenlet-dbg
+Suggests: python-greenlet-dbg, python-greenlet-dev, python-greenlet-doc
 Description: Lightweight in-process concurrent programming
  The greenlet package is a spin-off of Stackless, a version of CPython that
  supports micro-threads called "tasklets". Tasklets run pseudo-concurrently
diff -Nru python-greenlet-0.3.3/debian/python-greenlet.install python-greenlet-0.3.3/debian/python-greenlet.install
--- python-greenlet-0.3.3/debian/python-greenlet.install	2012-02-11 20:11:04.000000000 +0000
+++ python-greenlet-0.3.3/debian/python-greenlet.install	2012-05-17 09:46:42.000000000 +0100
@@ -1,2 +1,2 @@
-usr/lib/python*/*-packages/*[!_][!_].so
 usr/lib/python*/*-packages/*.egg-info
+usr/lib/python*/*-packages/*[!_][!_].so
diff -Nru python-greenlet-0.3.3/debian/rules python-greenlet-0.3.3/debian/rules
--- python-greenlet-0.3.3/debian/rules	2012-02-11 20:11:04.000000000 +0000
+++ python-greenlet-0.3.3/debian/rules	2012-05-17 10:12:00.000000000 +0100
@@ -3,7 +3,7 @@
 PYVERSIONS := $(shell pyversions -sv)
 
 %:
-	dh $@ --with quilt
+	dh $@ --with python2
 
 override_dh_auto_clean:
 	rm -rf build/
@@ -24,14 +24,7 @@
 	touch test-python-$*-stamp
 endif
 
-override_dh_strip:
-ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
-	# See bug #576014
-	dh_strip --dbg-package=python-greenlet-dbg
-	cd debian/python-greenlet-dbg/usr/lib/debug/usr/lib && mv pyshared pymodules
-endif
-
 override_dh_installdocs:
 	dh_installdocs --link-doc=python-greenlet
 
-.PHONY: override_dh_auto_clean override_dh_auto_build override_dh_auto_test override_dh_strip override_dh_installdocs
+.PHONY: override_dh_auto_clean override_dh_auto_build override_dh_auto_test override_dh_installdocs

Reply via email to