On Wed, Jun 06, 2012 at 10:08:49PM +0000, Cyril Roelandt wrote: > Package: lua-posix > Severity: normal > Tags: patch > > Dear Maintainer, > > lua-posix currently fails to build on hurd-i386. The attached patch > fixes this issue. It also checks the return value of sysconf() on > non-GNU systems.
Many thanks for the patch! > + int error = !!(b==NULL); > + if (!error) > + lua_pushstring(L, b); > + return error ? pusherror(L, ".") : 1; Could you explain why your wrote the code like you did and not in the following obvious way: if (b != NULL) { lua_pushstring(L, b); return 1; } else { return pusherror(L, "get_current_dir_name"); } What is this abundance of !! for? Why should the error message be "."? Cheers -- Enrico Tassi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org