Le dimanche 10 juin 2012 15:47:00, Olivier Andrieu a écrit : [...] > > Hi Olivier, > > > > I've found a typo in "ocamlsdl-0.9.0/src/sdlevent_stub.c", > > here is a patch. > > Thanks, it's committed to the CVS repo. > Should I make a new tarball release ?
Hi Olivier, A bug was found on the beginner list. It was impossible to change the volume of musics. There are 2 possible way to fix it. You can choose one of these patch. Cheers
diff -Naur ocamlsdl-0.9.0.orig/src/sdlmixer.ml ocamlsdl-0.9.0.sdlmixer_setvolume_music/src/sdlmixer.ml --- ocamlsdl-0.9.0.orig/src/sdlmixer.ml 2012-06-14 17:08:41.000000000 +0200 +++ ocamlsdl-0.9.0.sdlmixer_setvolume_music/src/sdlmixer.ml 2012-06-14 17:09:20.000000000 +0200 @@ -117,7 +117,7 @@ external setvolume_channel : channel -> float -> unit = "sdlmixer_setvolume_channel" external setvolume_chunk : chunk -> float -> unit = "sdlmixer_setvolume_chunk" -external setvolume_music : music -> float -> unit = "sdlmixer_setvolume_music" +external setvolume_music : float -> unit = "sdlmixer_setvolume_music" (* Stopping playing *) diff -Naur ocamlsdl-0.9.0.orig/src/sdlmixer.mli ocamlsdl-0.9.0.sdlmixer_setvolume_music/src/sdlmixer.mli --- ocamlsdl-0.9.0.orig/src/sdlmixer.mli 2012-06-14 17:08:41.000000000 +0200 +++ ocamlsdl-0.9.0.sdlmixer_setvolume_music/src/sdlmixer.mli 2012-06-14 17:09:30.000000000 +0200 @@ -253,7 +253,7 @@ function *) external volume_music : music -> float = "sdlmixer_volume_music" -external setvolume_music : music -> float -> unit = "sdlmixer_setvolume_music" +external setvolume_music : float -> unit = "sdlmixer_setvolume_music" external pause_music : unit -> unit = "sdlmixer_pause_music"
diff -Naur ocamlsdl-0.9.0.orig/src/sdlmixer_stub.c ocamlsdl-0.9.0.sdlmixer_setvolume_music/src/sdlmixer_stub.c --- ocamlsdl-0.9.0.orig/src/sdlmixer_stub.c 2011-04-10 14:44:12.000000000 +0200 +++ ocamlsdl-0.9.0.sdlmixer_setvolume_music/src/sdlmixer_stub.c 2012-06-14 16:58:55.000000000 +0200 @@ -427,7 +427,7 @@ } CAMLprim value -sdlmixer_setvolume_music(value vol) +sdlmixer_setvolume_music(value music, value vol) { Mix_VolumeMusic(Double_val(vol) * MIX_MAX_VOLUME ); return Val_unit;