Hi, Thanks for committing the kFreeBSD patches.
I hope this isn't too late, but I just tested building 3.10.8.16-1 from git on kfreebsd-i386, and it failed due to a -Wunused-but-set-variable that I didn't notice before in some FreeBSD-specific code. Attached is another patch to fix this and allows a successful build. Thanks again! Regards, -- Steven Chamberlain ste...@pyro.eu.org
From: Steven Chamberlain <ste...@pyro.eu.org> Subject: Fix a -Wunused-but-set-variable in some FreeBSD-specific code Bug-Debian: http://bugs.debian.org/670836 --- libv8-3.10.8.16.orig/src/platform-freebsd.cc 2012-04-17 12:57:53.000000000 +0100 +++ libv8-3.10.8.16/src/platform-freebsd.cc 2012-06-15 01:08:30.267121829 +0100 @@ -548,12 +548,9 @@ public: FreeBSDMutex() { pthread_mutexattr_t attrs; - int result = pthread_mutexattr_init(&attrs); - ASSERT(result == 0); - result = pthread_mutexattr_settype(&attrs, PTHREAD_MUTEX_RECURSIVE); - ASSERT(result == 0); - result = pthread_mutex_init(&mutex_, &attrs); - ASSERT(result == 0); + CHECK_EQ(0, pthread_mutexattr_init(&attrs)); + CHECK_EQ(0, pthread_mutexattr_settype(&attrs, PTHREAD_MUTEX_RECURSIVE)); + CHECK_EQ(0, pthread_mutex_init(&mutex_, &attrs)); } virtual ~FreeBSDMutex() { pthread_mutex_destroy(&mutex_); }
