On Wed, Jun 27, 2012 at 11:37:14PM +0100, Roger Leigh wrote: > On Wed, Jun 27, 2012 at 05:03:54PM -0500, Serge Hallyn wrote: > > Quoting Roger Leigh (rle...@codelibre.net): > > > On Wed, May 30, 2012 at 01:11:55PM -0500, Serge Hallyn wrote: > > > > Here is a debdiff showing the change I was suggesting. It works under > > > > debootstrap. The !ischroot case is unchanged, as is the case under > > > > chroot where /dev is a mounpoint. > > > > > > I can't see anything wrong with this after considering all the > > > different conditions it could run in, so it's applied in git > > > (minor whitespace changes only), and will be in the next upload. > > > > Thanks - however to the bottom of the ubuntu bug (in particular > > https://bugs.launchpad.net/launchpad/+bug/974584/comments/20 > > and > > https://bugs.launchpad.net/launchpad/+bug/974584/comments/21 > > ) vorlon has proposed an improved variation. Thanks and sorry > > for the inconvenience.
> You just missed the cutoff, since I just spent the evening > testing for upload. I didn't want to retest everything again, > so vorlon's improvement will have to go into the next upload. > His outline of the various different end states is good, and > highlights just how annoying it is having to handle upgrades > in chroots. Better covering them is very desirable where > possible, though as he points out, there are certain cases > where it's simply not possible to safely proceed. I wouldn't put it quite like that. I would say rather that it's not always possible to fix up the chroot on the admin's behalf. But we can at least be sure not to make things worse. > I'll review and test this for the next upload. > BTW, vorlon's code uses "mountpoint -q /dev/". Is the > trailing / in /dev/ significant, e.g. to cope with /dev > being a symlink? It had no significance when I wrote it. I assume this was just a typo on my part, or I cut'n'pasted from somewhere else. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: Digital signature