tags 679390 + patch
thanks
On 2012-06-28 13:03 +0200, Sven Joachim wrote:
> Package: debian-el
> Version: 35.2
> Severity: normal
>
> M-x debian-bug does not run the package's bug script if it is a
> symlink. So far I have tracked this down to debian-bug-find-bug-script
> which returns nil in such cases:
>
> (debian-bug-find-bug-script "xserver-xorg-video-nouveau") => nil
>
> (debian-bug-find-bug-script "xserver-xorg-core") =>
> "/usr/share/bug/xserver-xorg-core/script"
>
> However, these packages actually use the same script:
>
> ,----
> | $ file /usr/share/bug/xserver-xorg-video-nouveau/script
> | /usr/share/bug/xserver-xorg-video-nouveau/script: symbolic link to
> `../xserver-xorg-core/script'
> `----
>
> I'm 99% sure this had worked in the past.
Looks like it broke more than two years ago, though.
> Wonder what broke it.
That part was easy, it's the rather bogus check for executability in
debian-bug-file-is-executable. The following one-liner fixes it:
--8<---------------cut here---------------start------------->8---
diff -Nru emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el
emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el
--- emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el 2010-06-22
23:55:44.000000000 +0200
+++ emacs-goodies-el-35.2/elisp/debian-el/debian-bug.el 2012-06-28
13:18:12.000000000 +0200
@@ -781,7 +781,7 @@
"Return non-nil if FILE is executable. Otherwise nil is returned."
(and
(file-regular-p file)
- (string-match "-..x..x..x" (nth 8 (file-attributes file)))))
+ (file-executable-p file)))
(defun debian-bug-find-bug-script (package)
"Return the full path name of the bug script of PACKAGE.
--8<---------------cut here---------------end--------------->8---
Cheers,
Sven
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
