Hi,

This makes other lua linking program to fail to build under wheezy.  Bad.  I
will mark this important.

I see the same problem using this -dev package.  Specifically, you see
problem under "set -x" as:

$ gcc -c dump.c `pkg-config --cflags --libs lua5.1`
++ pkg-config --cflags --libs lua5.1
+ gcc -c dump.c '-DDEB_HOST_MULTIARCH=\"x86_64-linux-gnu\"' 
-I/usr/include/lua5.1 -llua5.1
<command-line>:0:21: warning: missing terminating " character [enabled by 
default]

You see at lease current pkg-config is putting string with single quotes.
This is independent of shell I used (dash, bash).

This is clearly regression of: lua5.1 (5.1.5-2):

   * Put in the pkg-config .pc file -DDEB_HOST_MULTIARCH so that including
     lua.h (and consequently luaconf.h) works fine even if one is not using
     debhelpers (Closes: #671286, LP: #977813)
 -- Enrico Tassi <gareuselesi...@debian.org>  Thu, 03 May 2012 14:34:16 +0200

This can be fixed by debian/lua*.pc.in (just by above argument)

-Cflags: -I${includedir}/${lib_name_include} 
-DDEB_HOST_MULTIARCH=\"${deb_host_multiarch}\"
+Cflags: -I${includedir}/${lib_name_include} 
-DDEB_HOST_MULTIARCH=${deb_host_multiarch}

I know this may be a minimum fix for under freeze situation.  But is this fix 
the best
way?  I do not see any other packages on my system uses this approach.

In short, why not set according to the architecture build:

-----
libdir=${prefix}/lib/x86_64-linux-gnu
-----

This should solve problem as others (>194 packages) which moved to multi-arch
on my system.  Use of -D option in this way is only by lua. Any setting as
above is the normal solution and revert change in previous upload by the
following instead.

-Cflags: -I${includedir}/${lib_name_include} 
-DDEB_HOST_MULTIARCH=\"${deb_host_multiarch}\"
+Cflags: -I${includedir}/${lib_name_include}

Regards,

Osamu

PS: Here is my proof for package situation.

$ cd /usr/lib/x86_64-linux-gnu/pkgconfig
$ ls -1 *.pc|wc -l 
200
$ grep -e "-DDEB_HOST_MULTIARCH" *
lua5.1-c++.pc:Cflags: -I${includedir}/${lib_name_include} 
-DDEB_HOST_MULTIARCH=\"${deb_host_multiarch}\"
lua5.1.pc:Cflags: -I${includedir}/${lib_name_include} 
-DDEB_HOST_MULTIARCH=\"${deb_host_multiarch}\"
lua5.2.pc:Cflags: -I${includedir}/${lib_name_include} 
-DDEB_HOST_MULTIARCH=\"${deb_host_multiarch}\"
$ grep "^libdir" *|grep -v x86_64-linux-gnu
libgcj13.pc:libdir=/usr/lib
libgcj-4.7.pc:libdir=/usr/lib
lua5.1-c++.pc:libdir=${prefix}/lib
lua5.1.pc:libdir=${prefix}/lib
lua5.2.pc:libdir=${prefix}/lib
uuid.pc:libdir=${libexecdir}
$ grep "^libdir" *|grep x86_64-linux-gnu|wc -l
194
$ grep -e libdir atk.pc
libdir=${prefix}/lib/x86_64-linux-gnu
Libs: -L${libdir} -latk-1.0

See what others are doing.

FYI: 
uuid.pc:libdir=${libexecdir}
  This has libexecdir=${prefix}/lib/x86_64-linux-gnu .  So effectively same.
libgcj13.pc:libdir=/usr/lib
libgcj-4.7.pc:libdir=/usr/lib
  These may be broken.  I will check later.





-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to