On 20.08.2012 14:04, Jakub Adam wrote: > Hi Felix, > > On 16.8.2012 11:04, Felix Geyer wrote: >> I noticed some issues in the copyright file: >> >> - This one is missing: >> ./core/palettemodel.cpp: Copyright (C) 2010 Ariya >> Hidayat<ariya.hida...@gmail.com> >> >> - tools/ has been moved to core/tools/ >> >> - cmake/* is missing. >> Some of those files don't have a license header. >> It would be good to check with upstream under what license they are >> released. > > I fixed what I could figure out myself, for the rest of files in cmake/ I > asked > upstream [1], missing license headers are now added in their git [2] and also > in our d/copyright.
Great, thanks! Upstream has released version 1.2.1 in the meantime. I noticed that you've removed 3rdparty/qt/private in the upstream tarball. This needs to be documented in README.source and preferably "+repack" added to the upstream version number. In this case however it would be much easier to keep them in the tarball and just remove those files in debian/rules before building. Felix -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org