On 20:32 Fri 24 Aug     , Jakub Wilk wrote:
> You create the empty suckless-tools_${version}.orig.tar.gz tarball
> in the wrong directory.

Fixed

> Why do you redirect tar's stderr to /dev/null?
Removed this too

> I recommend passing these options to tar, so that the user's
> name/group/umask are not leaked:
> 
> --owner root --group root --mode a+rX
Done

<snip>

Warm Regards
-- 
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4  C96B 6C8F 74AE 8770 0B7E

Attachment: signature.asc
Description: Digital signature

Reply via email to