David Prévot wrote: [...] > Other members of the list may have other remarks and improvements to > propose, thus this formal call for review.
Yes, again the other templates in the package could do with a few changes. > Template: lsh-server/lshd_port > Type: string > Default: 22 > _Description: lsh server port: > The default port for lshd is 22. If you would like lshd to run on a > different port, please specify the alternative port here. If you specify > 22, you will need to manually disable any other ssh servers you have > running on port 22, other than OpenSSH (from the `openssh-server' package). > OpenSSH will be automatically disabled, if you choose 22 here. We usually try to avoid templates talking about their defaults, but here it seems unavoidable. Throughout: some Germanic-looking commas, unnecessary focus on what I would like, and protocols like SSH in lowercase. With those and several other minor tweaks: The default port for lshd is 22. If lshd should run on a different port, please specify the alternative port here. If you specify 22, you will need to manually disable any other SSH servers running on port 22, other than OpenSSH (from the package openssh-server), which will be disabled automatically if you choose 22 here. > Template: lsh-server/sftp > Type: boolean > Default: false > _Description: Enable the sftp subsystem? > If you want to use sftp with lsh, you will need this subsystem. > Please bear in mind, that it's still experimental. Therefore the default > is disabled but can be enabled now or later by manually changing > /etc/default/lsh-server. > . > Please choose whether you want to use the EXPERIMENTAL sftp support now. The default isn't disabled; it's set to "false". It's the SFTP support that's disabled. Reshuffling: _Description: Enable the SFTP subsystem? Please choose whether you want to use the EXPERIMENTAL lsh SFTP support. . Since it is experimental, the default is for it to be disabled, but it can be enabled now or later by manually changing /etc/default/lsh-server. In the control file: > Package: lsh-utils > Architecture: any > Depends: nettle-bin (>= 2.0-2), ${shlibs:Depends}, ${misc:Depends} > Recommends: openssh-blacklist, openssh-blacklist-extra > Suggests: lsh-server, lsh-client, lsh-doc > Description: Secure Shell v2 (SSH2) protocol utilities > lsh is GNU GPL'd implementation of the Secure Shell protocol version > 2 (SSH2). The SSH (Secure SHell) protocol is a secure replacement for > rlogin, rsh and rcp. Another mutant spelling of GPLed. lsh is a GPLed implementation of the Secure SHell protocol version 2 (SSH2), a secure replacement for rlogin, rsh, and rcp. But is its license really the only thing notable about this implementation? And... Why The Name? > . > This package contains the lsh utilities. This includes programs such > as lsh-keygen, lsh-writekey (both programs for public/private key > generation), lsh-authorize (for automatic remote key authentication), > ssh-conv (utilities for converting between various public & private > key formats), and a number of other utilities for use with both the > lsh server and client. > . > In some countries it may be illegal to use any encryption at all > without a special permit. I would also eliminate that ampersand, but otherwise this is fine as far as it goes. It's just missing a reason why anyone would care. [...] > Package: lsh-doc > Architecture: all > Section: doc > Depends: dpkg (>= 1.15.4) | install-info, ${misc:Depends} > Suggests: lsh-utils, lsh-server, lsh-client > Conflicts: lsh-utils (<< 1.0.2-3) > Breaks: lsh-utils-doc (<< 2.0.4-dfsg-1) > Replaces: lsh-utils-doc (<< 2.0.4-dfsg-1) > Description: Secure Shell v2 (SSH2) client / server / utilities documentation ^^^^^^^^^^^^^^^^^^^^^^^^^^^ That's awkward, and not really necessary. > lsh is GNU GPL'd implementation of the Secure Shell > protocol version 2 (SSH2). The SSH (Secure SHell) protocol > is a secure replacement for rlogin, rsh and rcp. > . > This package contains the lsh documentation, including info > pages, manpages about the various protocols which lsh uses, > as well as various documents about lsh internals, protocols > and general lsh development. Slightly malformed list (you can't freely substitute "as well as" for "and"), and while I'm fixing it I'll add serial commas. -- JBR with qualifications in linguistics, experience as a Debian sysadmin, and probably no clue about this particular package
diff -ru lsh-utils-2.0.4-dfsg.pristine/debian/control lsh-utils-2.0.4-dfsg/debian/control --- lsh-utils-2.0.4-dfsg.pristine/debian/control 2012-06-30 16:58:54.000000000 +0100 +++ lsh-utils-2.0.4-dfsg/debian/control 2012-08-29 23:34:49.876411891 +0100 @@ -16,14 +16,13 @@ Recommends: openssh-blacklist, openssh-blacklist-extra Suggests: lsh-server, lsh-client, lsh-doc Description: Secure Shell v2 (SSH2) protocol utilities - lsh is GNU GPL'd implementation of the Secure Shell protocol version - 2 (SSH2). The SSH (Secure SHell) protocol is a secure replacement for - rlogin, rsh and rcp. + lsh is a GPLed implementation of the Secure SHell protocol version 2 + (SSH2), a secure replacement for rlogin, rsh, and rcp. . This package contains the lsh utilities. This includes programs such as lsh-keygen, lsh-writekey (both programs for public/private key generation), lsh-authorize (for automatic remote key authentication), - ssh-conv (utilities for converting between various public & private + ssh-conv (utilities for converting between various public and private key formats), and a number of other utilities for use with both the lsh server and client. . @@ -38,9 +37,8 @@ Recommends: openssh-blacklist-extra Suggests: lsh-client | openssh-client, lsh-doc Description: Secure Shell v2 (SSH2) protocol server - lsh is GNU GPL'd implementation of the Secure Shell - protocol version 2 (SSH2). The SSH (Secure SHell) protocol - is a secure replacement for rlogin, rsh and rcp. + lsh is a GPLed implementation of the Secure SHell protocol version 2 + (SSH2), a secure replacement for rlogin, rsh, and rcp. . This package contains the lsh server, lshd. This package is required to allow SSH2 logins to the local machine. @@ -56,12 +54,11 @@ Replaces: lsh-utils (<< 2.0.4-dfsg-1) Suggests: lsh-doc Description: Secure Shell v2 (SSH2) protocol client - lsh is GNU GPL'd implementation of the Secure Shell - protocol version 2 (SSH2). The SSH (Secure SHell) protocol - is a secure replacement for rlogin, rsh and rcp. + lsh is a GPLed implementation of the Secure SHell protocol version 2 + (SSH2), a secure replacement for rlogin, rsh, and rcp. . This package contains the lsh client used to log in to a remote lsh - or ssh2 server. + or SSH2 server. . In some countries it may be illegal to use any encryption at all without a special permit. @@ -74,14 +71,13 @@ Conflicts: lsh-utils (<< 1.0.2-3) Breaks: lsh-utils-doc (<< 2.0.4-dfsg-1) Replaces: lsh-utils-doc (<< 2.0.4-dfsg-1) -Description: Secure Shell v2 (SSH2) client / server / utilities documentation - lsh is GNU GPL'd implementation of the Secure Shell - protocol version 2 (SSH2). The SSH (Secure SHell) protocol - is a secure replacement for rlogin, rsh and rcp. +Description: Secure Shell v2 (SSH2) documentation + lsh is a GPLed implementation of the Secure SHell protocol version 2 + (SSH2), a secure replacement for rlogin, rsh, and rcp. . This package contains the lsh documentation, including info - pages, manpages about the various protocols which lsh uses, - as well as various documents about lsh internals, protocols + pages and manpages about the various protocols which lsh uses, + as well as various documents about lsh internals, protocols, and general lsh development. . In some countries it may be illegal to use any encryption diff -ru lsh-utils-2.0.4-dfsg.pristine/debian/lsh-server.templates lsh-utils-2.0.4-dfsg/debian/lsh-server.templates --- lsh-utils-2.0.4-dfsg.pristine/debian/lsh-server.templates 2012-06-30 16:57:33.000000000 +0100 +++ lsh-utils-2.0.4-dfsg/debian/lsh-server.templates 2012-08-29 23:15:28.268411143 +0100 @@ -2,22 +2,20 @@ Type: string Default: 22 _Description: lsh server port: - The default port for lshd is 22. If you would like lshd to run on a - different port, please specify the alternative port here. If you specify - 22, you will need to manually disable any other ssh servers you have - running on port 22, other than OpenSSH (from the `openssh-server' package). - OpenSSH will be automatically disabled, if you choose 22 here. + The default port for lshd is 22. If lshd should run on a different port, + please specify the alternative port here. If you specify 22, you will + need to manually disable any other SSH servers running on port 22, other + than OpenSSH (from the package openssh-server), which will be disabled + automatically if you choose 22 here. Template: lsh-server/sftp Type: boolean Default: false _Description: Enable the sftp subsystem? - If you want to use sftp with lsh, you will need this subsystem. - Please bear in mind, that it's still experimental. Therefore the default - is disabled but can be enabled now or later by manually changing - /etc/default/lsh-server. + Please choose whether you want to use the EXPERIMENTAL lsh SFTP support. . - Please choose whether you want to use the EXPERIMENTAL sftp support now. + Since it is experimental, the default is for it to be disabled, but it + can be enabled now or later by manually changing /etc/default/lsh-server. Template: lsh-server/purge_hostkey Type: boolean @@ -31,4 +29,4 @@ Template: lsh-server/extra_args Type: string -Description: Additional arguments to pass to lshd: +_Description: Additional arguments to pass to lshd:
Template: lsh-server/lshd_port Type: string Default: 22 _Description: lsh server port: The default port for lshd is 22. If lshd should run on a different port, please specify the alternative port here. If you specify 22, you will need to manually disable any other SSH servers running on port 22, other than OpenSSH (from the package openssh-server), which will be disabled automatically if you choose 22 here. Template: lsh-server/sftp Type: boolean Default: false _Description: Enable the sftp subsystem? Please choose whether you want to use the EXPERIMENTAL lsh SFTP support. . Since it is experimental, the default is for it to be disabled, but it can be enabled now or later by manually changing /etc/default/lsh-server. Template: lsh-server/purge_hostkey Type: boolean Default: true _Description: Remove host key on purge? When this package is installed, a host key is generated to authenticate your host. . Please choose whether you want to purge the host key when the package is removed. Template: lsh-server/extra_args Type: string _Description: Additional arguments to pass to lshd:
Source: lsh-utils Section: net Priority: extra Maintainer: Magnus Holmgren <holmg...@debian.org> Uploaders: Stefan Pfetzing <dream...@dreamind.de> Standards-Version: 3.9.3 Build-Depends: dpkg-dev (>= 1.15.7), debhelper (>= 7), dh-autoreconf, automake, libgmp-dev, zlib1g-dev | libz-dev, liboop-dev, libxau-dev, nettle-dev (>= 2.2~), nettle-bin, texinfo (>= 4.2), guile-1.6 | scsh-0.6, heimdal-dev, libwrap0-dev | libwrap-dev, libpam0g-dev | libpam-dev, libreadline-dev, m4 Homepage: http://www.lysator.liu.se/~nisse/lsh/ Package: lsh-utils Architecture: any Depends: nettle-bin (>= 2.0-2), ${shlibs:Depends}, ${misc:Depends} Recommends: openssh-blacklist, openssh-blacklist-extra Suggests: lsh-server, lsh-client, lsh-doc Description: Secure Shell v2 (SSH2) protocol utilities lsh is a GPLed implementation of the Secure SHell protocol version 2 (SSH2), a secure replacement for rlogin, rsh, and rcp. . This package contains the lsh utilities. This includes programs such as lsh-keygen, lsh-writekey (both programs for public/private key generation), lsh-authorize (for automatic remote key authentication), ssh-conv (utilities for converting between various public and private key formats), and a number of other utilities for use with both the lsh server and client. . In some countries it may be illegal to use any encryption at all without a special permit. Package: lsh-server Architecture: any Provides: ssh-server Depends: lsh-utils (= ${binary:Version}), openssh-blacklist, ${shlibs:Depends}, ${misc:Depends} Recommends: openssh-blacklist-extra Suggests: lsh-client | openssh-client, lsh-doc Description: Secure Shell v2 (SSH2) protocol server lsh is a GPLed implementation of the Secure SHell protocol version 2 (SSH2), a secure replacement for rlogin, rsh, and rcp. . This package contains the lsh server, lshd. This package is required to allow SSH2 logins to the local machine. . In some countries it may be illegal to use any encryption at all without a special permit. Package: lsh-client Architecture: any Depends: nettle-bin, lsh-utils (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends} Breaks: lsh-utils (<< 2.0.4-dfsg-1) Replaces: lsh-utils (<< 2.0.4-dfsg-1) Suggests: lsh-doc Description: Secure Shell v2 (SSH2) protocol client lsh is a GPLed implementation of the Secure SHell protocol version 2 (SSH2), a secure replacement for rlogin, rsh, and rcp. . This package contains the lsh client used to log in to a remote lsh or SSH2 server. . In some countries it may be illegal to use any encryption at all without a special permit. Package: lsh-doc Architecture: all Section: doc Depends: dpkg (>= 1.15.4) | install-info, ${misc:Depends} Suggests: lsh-utils, lsh-server, lsh-client Conflicts: lsh-utils (<< 1.0.2-3) Breaks: lsh-utils-doc (<< 2.0.4-dfsg-1) Replaces: lsh-utils-doc (<< 2.0.4-dfsg-1) Description: Secure Shell v2 (SSH2) documentation lsh is a GPLed implementation of the Secure SHell protocol version 2 (SSH2), a secure replacement for rlogin, rsh, and rcp. . This package contains the lsh documentation, including info pages and manpages about the various protocols which lsh uses, as well as various documents about lsh internals, protocols, and general lsh development. . In some countries it may be illegal to use any encryption at all without a special permit.