Am Sonntag, den 26.08.2012, 14:29 -0400 schrieb James McCoy: > Thanks to both of you for working on this functionality. The patches so > far look good. > > On Sun, Aug 26, 2012 at 03:30:44PM +0200, Andreas Tille wrote: > > I attached another Git formated patch and repeat my question whether > > it might make sense to directly commit to the devscripts repository. > > We can just as easily pull from another git repository > (e.g., git.debian.org/users/tille/devscripts.git) when we're ready to > merge the patches. I'd really rather not have features being added > right now since we're in a freeze and that makes it harder to prepare > Wheezy-targeted uploads.
The current changes in our git repository fix two bugs and I like to get these fixes into wheezy. The new script origtargz was also added and I dunno if this scripts prevents us from getting the fixes into wheezy. Maybe we should move origtargz into an experimental branch. You could push your uscan changes into an 'experimental' branch in our git repository if you want. Before merging your changes into the master branch after the release of wheezy, I like to see test cases to demonstrate the correct functioning. Adding test cases is extra work in the beginning, but will pay off later. devscripts comes with an growing test suite in tests/. The test suite uses shunit2. There is currently one test for uscan, but this is an online test. It would be great if uscan could be modified to work locally for the tests. This requires more Perl foo than I currently have. You might want to look an DPU [1]. It is a test framework for Debian tools and might be useful for us. [1] http://blog.pault.ag/post/30552124986/a-bit-more-on-dpu -- Benjamin Drung Debian & Ubuntu Developer
signature.asc
Description: This is a digitally signed message part
