Control: reopen -1 2.2.3-3

Looking through the diff for the upload closing this bug, I spotted
this:

+    if which ucfr >/dev/null; then
+        ucfr --purge foo /etc/fusioninventory/agent.conf
+    fi

Your package isn't named "foo", so the above invocation is obviously
incorrect. The registering of the file also looks odd:

+    ucf /usr/share/doc/fusioninventory-agent/agent.cfg 
/etc/fusioninventory/agent.cfg
+    ucfr fusioninventory-agent /etc/fusioninventory/agent.

I'm assuming the second line is missing a "cfg"?

The postinst and postrm also seem confused as to what the configuration
file is called:

+       rm -f /etc/fusioninventory/agent.conf$ext
+    rm -f /etc/fusioninventory/agent.conf
+        ucf --purge /etc/fusioninventory/agent.conf
+        ucfr --purge foo /etc/fusioninventory/agent.conf
+    ucf /usr/share/doc/fusioninventory-agent/agent.cfg 
/etc/fusioninventory/agent.cfg

A quick look over the rest of the package suggests it should be .cfg?

Finally, from a reviewer's perspective, it would have been helpful if
the changes to the postrm didn't include noise such as

+  remove)
+    # This package is being removed, but its configuration has not yet
+    # been purged.
+    :
+
+    # Remove diversion
+    : dpkg-divert --package foo --remove --rename \
+    :             --divert /usr/bin/other.real /usr/bin/other
+
+    # ldconfig is NOT needed during removal of a library, only during
+    # installation

Regards,

Adam


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to