Package: powertop
Version: 2.2-0.1
Severity: normal
Tags: upstream patch

in the html output from powertop, in the "Tuning" tab, i see:

   Wireless Power Saving for interface wlan0

with the recommendation to run:

   iw dev wlan0 set power_save off

This seems backward.  The attached patch reverses the sense to make it
do the right thing.

   --dkg


-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing'), (200, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages powertop depends on:
ii  libc6             2.13-37
ii  libgcc1           1:4.7.2-4
ii  libncursesw5      5.9-10
ii  libnl-3-200       3.2.7-4
ii  libnl-genl-3-200  3.2.7-4
ii  libpci3           1:3.1.9-5
ii  libstdc++6        4.7.2-4
ii  libtinfo5         5.9-10

powertop recommends no packages.

Versions of packages powertop suggests:
ii  cpufrequtils       008-1
ii  laptop-mode-tools  1.61-1
ii  libjs-jquery       1.7.2+dfsg-1

-- no debconf information
diff --git a/src/tuning/wifi.cpp b/src/tuning/wifi.cpp
index 38d9be6..77cdfcc 100644
--- a/src/tuning/wifi.cpp
+++ b/src/tuning/wifi.cpp
@@ -47,8 +47,8 @@ wifi_tunable::wifi_tunable(const char *_iface) : tunable("", 1.5, _("Good"), _("
 	strcpy(iface, _iface);
 	sprintf(desc, _("Wireless Power Saving for interface %s"), iface);
 
-	sprintf(toggle_good, "iw dev %s set power_save off", iface);
-	sprintf(toggle_bad, "iw dev %s set power_save on", iface);
+	sprintf(toggle_good, "iw dev %s set power_save on", iface);
+	sprintf(toggle_bad, "iw dev %s set power_save off", iface);
 }
 
 int wifi_tunable::good_bad(void)

Reply via email to