Hi Andrew! Andrew Chadwick wrote: > On 04/01/13 13:20, Daniel Baumann wrote: > > anyhow, if you need a sponsor to upload the package, let me know.
I was also thinking about ITA'ing mypaint, because I don't want that it drops from Debian and, like Daniel, I sponsored it in the past, too. So I'm happy to see that someone else seems to care more than I would have done, and I'd be happy to sponsor it again, too. > Heh :) I'm working on a package up for review at > https://mentors.debian.net/package/mypaint A short review: I miss one thing in the changelog: You fixed http://bugs.debian.org/660881 but didn't mention that in the changelog. Another thing which makes me wonder is this lintian warning: "I: mypaint: arch-dep-package-has-big-usr-share 3497kB 86%" So, despite there is already a mypaint-data package, the mypaint package contains 86% arch-independent stuff? This seems to be a regression from 1.0.0-1, as http://lintian.debian.org/maintainer/gur...@phys.ethz.ch.html#mypaint doesn't list that warning. I'd like to see the above issues fixed before uploading the package. Other lintian warnings which are less severe, but should be easily fixed: I: mypaint source: unused-license-paragraph-in-dep5-copyright cc-by-3.0-us (paragraph at line 388) I: mypaint: desktop-entry-contains-encoding-key usr/share/applications/mypaint.desktop:3 Encoding I: mypaint: spelling-error-in-copyright developper developer I: mypaint-data: spelling-error-in-copyright developper developer While I'd be happy to see them fixed in 1.1.0-1, too, I'd sponsor 1.1.0-1 without them being fixed if they'll be fixed in 1.1.0-2. :-) Oh, and a very minor style thingie: In the changelog entry, you sometimes use "#" before a bug number and sometimes not. I'd decide for one way and stay with it. > with public git-buildpackage style git repository at > https://github.com/achadwick/mypaint-debian if you'd like to take a > look or comment on it. There are a couple of issues that need > addressing right now, so thanks for the offer. I see you're already working on the next steps. Cool! One question here: Why changing http://mypaint.intilinux.com/ to http://mypaint.info/ when http://mypaint.info/ redirects to http://mypaint.intilinux.com/? Regards, Axel -- ,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE `- | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
