On Wed, Dec 26, 2012 at 10:07:18PM +0000, Nick Leverton wrote: > * Package name : mp3cat > Version : 0.5-1 > Upstream Author : Tom Clegg <t...@tomclegg.net> > * URL : http://tomclegg.net/mp3cat > * License : GPL-2+ > Section : sound
I had a look at your package and here are some remarks. debian/control: The Vcs-Svn header in the source section points to the upstream svn, but the header should be pointing to the repository containing the debian/ files. Would it be possible to mark mp3cat as Multi-Arch: foreign? debian/patches/*.patch: The patches contain useful headers with useless template values. Both patches seem appropriate for upstream submission. Did you do that already? Can you document the submission status in those headers? debian/rules: You pass the /usr prefix via $(DESTDIR). This is not wrong, but uncommon. Maybe you could extend the patch that adds DESTDIR to also add PREFIX? That would be useful for other distributions as well. It would also likely remove the need to override dh_auto_install. "# Sample debian/rules that uses debhelper." does not describe this file. It seems wrong. debian/source.lintian-overrides: Why do you override missing-license-text-in-dep5-copyright? I'd guess that lintian is confused by the empty line after the Format header in the middle of the header paragraph. If lintian is really wrong here, please file a bug against lintian instead of overriding the warning, because it should be possible to get this right. debian/copyright: You claim your copyright on debian/*, but debian/doc/mp3cat.html seems like a verbatim copy of the upstream website. Could you check the attribution on the directory? Helmut -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
