Package: smokeping
Version: 2.6.8-1.1
Severity: normal
Tags: patch

Hello,

I have a smokeping running with an other configuration (lxc, but guess
it would be the same if a user had a smokeping running with an alternate
configuration, or in a chroot, ...)

Init script only search for the binary running, without checking the
pidfile. The pidfile is correctly generated and placed, just not used to
check status on start or status.

# /etc/init.d/smokeping.orig status
[ ok ] Checking latency logger daemon status: smokeping (status 0).
# /etc/init.d/smokeping status
[ ok ] Checking latency logger daemon status: smokeping (status 1).

diff included to make pidofproc use the pidfile.

-- System Information:
Debian Release: 7.0
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages smokeping depends on:
ii  adduser                 3.113+nmu3
ii  debianutils             4.3.2
ii  fping                   3.2-1
ii  libcgi-fast-perl        5.14.2-16
ii  libconfig-grammar-perl  1.10-1
ii  libdigest-hmac-perl     1.03+dfsg-1
ii  libjs-cropper           1.2.2-1
ii  libjs-prototype         1.7.0-2
ii  libjs-scriptaculous     1.9.0-2
ii  librrds-perl            1.4.7-2
ii  libsnmp-session-perl    1.13-1
ii  liburi-perl             1.60-1
ii  libwww-perl             6.04-1
ii  lsb-base                4.1+Debian8
ii  perl                    5.14.2-16
ii  ucf                     3.0025+nmu3

Versions of packages smokeping recommends:
ii  dnsutils            1:9.8.4.dfsg.P1-4
pn  echoping            <none>
pn  libsocket6-perl     <none>
ii  thttpd [httpd-cgi]  2.25b-11

Versions of packages smokeping suggests:
pn  curl                                       <none>
ii  exim4                                      4.80-7
ii  exim4-daemon-light [mail-transport-agent]  4.80-7
pn  libauthen-radius-perl                      <none>
ii  libio-socket-ssl-perl                      1.76-2
pn  libnet-dns-perl                            <none>
pn  libnet-ldap-perl                           <none>
pn  libnet-telnet-perl                         <none>
ii  openssh-client                             1:6.0p1-3

-- Configuration Files:
/etc/init.d/smokeping changed [not included]
/etc/smokeping/config.d/Alerts changed [not included]
/etc/smokeping/config.d/Database changed [not included]
/etc/smokeping/config.d/General changed [not included]
/etc/smokeping/config.d/Slaves changed [not included]
/etc/smokeping/config.d/Targets changed [not included]
/etc/smokeping/smokeping_secrets [Errno 13] Permission denied: 
u'/etc/smokeping/smokeping_secrets'

-- no debconf information
--- /etc/init.d/smokeping.orig	2012-02-26 19:25:29.000000000 +0100
+++ /etc/init.d/smokeping	2013-02-05 11:05:45.000000000 +0100
@@ -94,7 +94,7 @@
         check_config
         check_slave
         set +e
-        pidofproc "$DAEMON" > /dev/null
+        pidofproc -p "$PIDFILE" "$DAEMON" > /dev/null
         STATUS=$?
         set -e
         if [ "$STATUS" = 0 ]
@@ -177,7 +177,7 @@
         # 5-199    reserved (5-99 LSB, 100-149 distribution, 150-199 applications)
 
         set +e
-        pidofproc "$DAEMON" > /dev/null
+        pidofproc -p "$PIDFILE" "$DAEMON" > /dev/null
         STATUS=$?
         log_progress_msg "(status $STATUS)"
         log_end_msg 0

Reply via email to