On Fri, Feb 15, 2013 at 12:37:00PM +0000, Chris Butler wrote: > On Thu, Dec 22, 2011 at 11:06:49PM +0100, Adam Borowski wrote: > > Coding wise, it appears to be a trivial change: in > > terminal/terminal-widget.c terminal_widget_button_press_event(), on a middle > > click, if the hidden setting is false, it would proceed to paste. > > > > Would a patch of this kind be accepted? > > > > On one hand, it's an itch that annoys me personally. On the other hand, no > > one wants creeping featurism. You guys probably know better whether I > > should stop whining and accept less convenient pastes, or help changing > > that. > > Just to add my $0.02, this is also an issue I've come across, and I would > love to see a config option for turning this off as well. > > Did you get anywhere with writing a patch for this or sending the issue > upstream? If not I might look into it myself.
The patch I'm using on my own box is destructive and not good for public consumption (attached). Making that depend on a hidden setting would be easy, except for one issue: XFCE requires all strings to be translated, at least for a release. If I recall correctly, upstream at that point was in release mode, and I forgot about the issue (hey, on my system the problem has been dealt with :) ). -- ᛊᚨᚾᛁᛏᚣ᛫ᛁᛊ᛫ᚠᛟᚱ᛫ᚦᛖ᛫ᚹᛖᚨᚲ
diff -urd xfce4-terminal-0.4.8.orig/terminal/terminal-widget.c xfce4-terminal-0.4.8/terminal/terminal-widget.c --- xfce4-terminal-0.4.8.orig/terminal/terminal-widget.c 2011-06-21 22:32:31.000000000 +0200 +++ xfce4-terminal-0.4.8/terminal/terminal-widget.c 2011-12-23 00:56:31.886603008 +0100 @@ -399,6 +399,7 @@ if (event->button == 2 && event->type == GDK_BUTTON_PRESS) { +#if 0 /* middle-clicking on an URI fires the responsible application */ match = vte_terminal_match_check (VTE_TERMINAL (widget), event->x / VTE_TERMINAL (widget)->char_width, @@ -410,6 +411,7 @@ g_free (match); return TRUE; } +#endif } else if (event->button == 3 && event->type == GDK_BUTTON_PRESS) {