Package: devscripts
Version: 2.13.0
Severity: normal
Thanks for having fixed the bug #659231.
I have another one, now. The attached file "ImageIO.h" is part of CGAL-4.1.
Its license is LGPLv3+, but licensecheck, from devscripts 2.13.0, sees it as
UNKNOWN.
The reason is that the wording of the license is about *files* (plural)
instead of a software (singular).
The attached patch "0002-Fix-the-detection-of-L-A-GPL.patch" formatted with
git-format-patch, fixes that bug. It replaces "it" by "(it|them)", so that the
regular expressions accept sentences about plural things.
--
Laurent Rineau, PhD
R&D Engineer at GeometryFactory http://www.geometryfactory.com/
Release Manager of the CGAL Project http://www.cgal.org/
// Copyright (c) 2005, 2006 ASCLEPIOS Project, INRIA Sophia-Antipolis (France)
// Copyright (c) 2007 Geometrica Project, INRIA Sophia-Antipolis (France)
// Copyright (c) 2008 GeometryFactory, Sophia-Antipolis (France)
// All rights reserved.
//
// The files in this directory are part of the ImageIO Library.
// You can redistribute them and/or modify them under the terms of the
// GNU Lesser General Public License as published by the Free Software Foundation;
// either version 3 of the License, or (at your option) any later version.
//
// Licensees holding a valid commercial license may use this file in
// accordance with the commercial license agreement provided with the software.
//
// These files are provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
// WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
// $URL: svn+ssh://scm.gforge.inria.fr/svn/cgal/branches/releases/CGAL-4.1-branch/CGALimageIO/include/CGAL/ImageIO.h $
// $Id: ImageIO.h 67097 2012-01-13 13:36:56Z lrineau $
//
#ifndef IMAGEIO_H
#define IMAGEIO_H
>From 625ee7156102169eab89ab2e661daa6bcdf41e48 Mon Sep 17 00:00:00 2001
From: Laurent Rineau <laurent.rin...@cgal.org>
Date: Tue, 19 Feb 2013 15:14:54 +0100
Subject: [PATCH 2/2] Fix the detection of (L|A)GPL.
The wording can be about files (plural) instead of a software (singular).
---
scripts/licensecheck.pl | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/licensecheck.pl b/scripts/licensecheck.pl
index ba9a2f2..9331c0e 100755
--- a/scripts/licensecheck.pl
+++ b/scripts/licensecheck.pl
@@ -451,15 +451,15 @@ sub parselicense {
$license = "GENERATED FILE";
}
- if ($licensetext =~ /((is free software.? )?you can redistribute it and\/or modify it|is licensed) under the terms of (version [^ ]+ of )?the (GNU (Library |Lesser )General Public License|LGPL)/i) {
+ if ($licensetext =~ /((is free software.? )?you can redistribute (it|them) and\/or modify (it|them)|is licensed) under the terms of (version [^ ]+ of )?the (GNU (Library |Lesser )General Public License|LGPL)/i) {
$license = "LGPL$gplver$extrainfo $license";
}
- if ($licensetext =~ /is free software.? you can redistribute it and\/or modify it under the terms of the (GNU Affero General Public License|AGPL)/i) {
+ if ($licensetext =~ /is free software.? you can redistribute (it|them) and\/or modify (it|them) under the terms of the (GNU Affero General Public License|AGPL)/i) {
$license = "AGPL$gplver$extrainfo $license";
}
- if ($licensetext =~ /(is free software.? )?you (can|may) redistribute it and\/or modify it under the terms of (?:version [^ ]+ (?:\(?only\)? )?of )?the GNU General Public License/i) {
+ if ($licensetext =~ /(is free software.? )?you (can|may) redistribute (it|them) and\/or modify (it|them) under the terms of (?:version [^ ]+ (?:\(?only\)? )?of )?the GNU General Public License/i) {
$license = "GPL$gplver$extrainfo $license";
}
--
1.7.7.6
