On Sun, Mar 3, 2013 at 4:31 PM, Paul Wise wrote: > I'm not planning to sponsor this but here is a review:
More review: You might want to try merging and or forwarding the Ubuntu patch and the patches in Ubuntu bugs: http://patches.ubuntu.com/t/tpb/tpb_0.6.4-2.3ubuntu3.patch http://dex.alioth.debian.org/census/Ubuntu/patches/t/tpb/tpb_0.6.4-2.3_tpb_0.6.4-2.3ubuntu3.patch https://bugs.launchpad.net/ubuntu/+source/tpb/+patches Likewise for the Gentoo, NetBSD and FreeBSD patches: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-laptop/tpb/files/ http://svnweb.freebsd.org/ports/head/deskutils/tpb/files/ http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/sysutils/tpb/patches/ None of the bugs in Debian/Ubuntu are marked as forwarded upstream, it would be a good idea to forward them upstream and then mark them as forwarded: http://bugs.debian.org/src:tpb https://bugs.launchpad.net/ubuntu/+source/tpb http://www.debian.org/Bugs/server-control#forwarded The package has a user interface, but there is no screenshot here: http://screenshots.debian.net/package/tpb You may want to review the debtags, there are some missing tags: http://debtags.debian.net/rep/todo/maint/prach...@gmail.com#tpb Does the code work on kFreeBSD? FreeBSD appears to have /dev/nvram and the patches above probably make it work. There is one duplicate file in the package, I would suggest dropping the copy in /u/s/d: http://dedup.debian.net/compare/tpb/tpb -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
