On 12.03.2013 21:45, Mathieu Trudel-Lapierre wrote: > Fair enough. I started, or more precisely cleaned up what I had a bit and > rebased on 0.7.990; it builds here on Ubuntu and I shipped it to a PPA to > build "cleanly":
Thanks for that! > https://launchpad.net/~network-manager/+archive/modemmanager-next/+sourcepub/3023373/+listing-archive-extra > > It builds fine in sbuild here with libqmi 1.0-1. I'll track it later to see > whether it completes this build. Then there is some work done by Marius > Kotsbak I'll merge, and I'll be ready for constructive criticism (ie. > sponsoring). I've had a quick look at it, a couple of comments: 1/ it would be nice if you could merge the 0.5.2.0-2 changelog from Debian. Easiest is probably if for 0.7.990 you change the version number to 0.7.990-1 and upload target to experimental and sync from there? 2/ multi-arch support [1] - Don't hard-code the pre-depends on multiarch-support, use Pre-Depends: ${misc:Pre-Depends} instead - Flag the library package as Multi-Arch: same - Haven't checked if other binary packages can be flagged as same or foreign, but that is not that important for now 3/ Missing build-depends on autopoint Since you are using autopoint in debian/rules and Debian buildds don't install Recommends, you need to add that dep. On the other hand, why do you need autopoint? 4/ debian/rules: autoreconf You don't call dh_autoreconf correctly if autogen.sh is not available, this way debian/rules clean will not restore to a proper state. Use what I have 0.5.2.0-2 and add a separate autoreconf make target autoreconf: ↦ intltoolize -f ↦ autoreconf -f -i override_dh_autoreconf: ↦ dh_autoreconf debian/rules -- autoreconf Fwiw, I don't think we need a if-def here. Use the explicit calls to the individual tools and once autogen.sh is available in the release tarball, rely on that. Fwiw, an alternative might be to build-depend on gnome-common and use gnome-autogen.sh, which should dtrt(tm) export NOCONFIGURE=true override_dh_autoreconf: ↦ dh_autoreconf -- gnome-autogen.sh Ping me when you have an updated package. I'm happy to upload to experimental then. Michael [1] http://wiki.debian.org/Multiarch/Implementation#Recipes_for_converting_packages -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
