Package: tinc
Version: 1.1~pre6-1
Severity: normal
Tags: patch

Hi,

when started by the init script, tinc does not honor the extra arguments set in /etc/default/tinc.

Thanks,
Gian Piero.

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages tinc depends on:
ii  dpkg          1.16.10
ii  install-info  4.13a.dfsg.1-10
ii  libc6         2.13-38
ii  liblzo2-2     2.06-1
ii  libncurses5   5.9-10
ii  libreadline6  6.2+dfsg-0.1
ii  libssl1.0.0   1.0.1e-2
ii  libtinfo5     5.9-10
ii  zlib1g        1:1.2.7.dfsg-13

tinc recommends no packages.

tinc suggests no packages.

-- Configuration Files:
/etc/default/tinc changed [not included]

-- no debconf information
Thu Apr  4 20:28:56 CEST 2013  Gian Piero Carrubba <[email protected]>
  * init script fails to pass extra arguments to tincd
    + remove the '--' as it is passed unaltered to tincd, preventing it to read
      trailing parameters
    + pass extra arguments also when restarting the daemon
diff -rN -u old-tinc-1.1~pre6/debian/tinc.init new-tinc-1.1~pre6/debian/tinc.init
--- old-tinc-1.1~pre6/debian/tinc.init	2013-04-04 21:23:04.563013650 +0200
+++ new-tinc-1.1~pre6/debian/tinc.init	2013-04-04 21:23:04.563013650 +0200
@@ -41,7 +41,7 @@
   egrep '^[ ]*[a-zA-Z0-9_-]+' $NETSFILE | while read net args; do
     echo -n " $net"
     case "$1" in
-      start) $CONTROL -n $net start -- $EXTRA $args ;;
+      start|restart) $CONTROL -n $net $1 $EXTRA $args ;;
       *) $CONTROL -n $net $1 ;;
     esac
   done

Reply via email to