Package: system-config-printer
Version: 1.3.7-4
Severity: normal

Dear Maintainer,
Apr 08 07:48:24 penelope /opt/gnome/etc/gdm/Xsession[4592]: 
(gnome-control-center:30104): printers-cc-panel-WARNING **: Install 
system-config-printer which provides DBus method "GroupPhysicalDevices" to 
group duplicates in device list.
Apr 08 07:48:24 penelope /opt/gnome/etc/gdm/Xsession[4592]: 
(gnome-control-center:30104): printers-cc-panel-WARNING **: Install 
system-config-printer which provides DBus method "GroupPhysicalDevices" to 
group duplicates in device list.
Apr 08 07:48:25 penelope /opt/gnome/etc/gdm/Xsession[4592]: 
(gnome-control-center:30104): printers-cc-panel-WARNING **: Install 
system-config-printer which provides DBus method "GroupPhysicalDevices" to 
group duplicates in device list.
Apr 08 07:48:25 penelope /opt/gnome/etc/gdm/Xsession[4592]: 
(gnome-control-center:30104): printers-cc-panel-WARNING **: 
GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name 
org.fedoraproject.Config.Printing was not provided by any .service files
Apr 08 07:48:25 penelope /opt/gnome/etc/gdm/Xsession[4592]: 
(gnome-control-center:30104): GLib-GIO-CRITICAL **: g_bus_get_sync: assertion 
`error == NULL || *error == NULL' failed
Apr 08 07:48:25 penelope /opt/gnome/etc/gdm/Xsession[4592]: 
(gnome-control-center:30104): printers-cc-panel-WARNING **: Failed to get 
session bus: (null)
Apr 08 07:48:25 penelope /opt/gnome/etc/gdm/Xsession[4592]: 
(gnome-control-center:30104): printers-cc-panel-WARNING **: Installation of the 
new printer failed.

This comes from system-config-printer not installing /usr/share/dbus-1
and scp-dbus-service.
I added a dbus force-reload in postinst to cope with the install of the service.


The attached patch is kind of a blob that fixes various issues (sorry, I mangled
it with debdiff).
Ie it fixes above dbus service missing but also upgrade to 1.4.0
of system-config-printer to cope with cups 1.6 api breakage
on its udev/udev-configure-printer.c . 

To end up I modified the debian/rules cleanbuilddir/python-cupshelpers::
as to remove cupshelpers/debug.py that the rules files add instead of 
non existant cupshelpers/options.py.

Best regards
Alban


-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8.0test0-06549-ga519a70 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages system-config-printer depends on:
ii  gnome-icon-theme    3.7.91-1
ii  python              2.7.3-13
ii  python-cups         1.9.62-1
ii  python-cupshelpers  1.4.0-1
ii  python-dbus         1.1.1-1
ii  python-glade2       2.24.0-3+b1
ii  python-gnome2       2.28.1+dfsg-1
ii  python-gtk2         2.24.0-3+b1
ii  python-libxml2      2.9.0+dfsg1-4
ii  python-notify       0.1.1-3
ii  python-support      1.0.15

Versions of packages system-config-printer recommends:
ii  cups-pk-helper              0.2.3-3
ii  system-config-printer-udev  1.4.0-1

Versions of packages system-config-printer suggests:
ii  python-gnomekeyring  2.32.0+dfsg-2+b1
ii  python-smbc          1.0.6-1+b1
pn  sessioninstaller     <none>

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/system-config-printer/jobviewer.py (from 
system-config-printer package)
debsums: changed file /usr/share/system-config-printer/printerproperties.py 
(from system-config-printer package)
debsums: changed file /usr/share/system-config-printer/statereason.py (from 
system-config-printer package)
diff -Nru system-config-printer-1.3.7/debian/changelog system-config-printer-1.4.0/debian/changelog
--- system-config-printer-1.3.7/debian/changelog	2013-01-25 21:53:20.000000000 +0100
+++ system-config-printer-1.4.0/debian/changelog	2013-04-08 08:26:06.000000000 +0200
@@ -1,3 +1,15 @@
+system-config-printer (1.4.0-1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Add /usr/share/dbus-1 to install to get the dbus services
+    and reload dbus in postinst.
+    Also add scp-dbus-service called by those dbus services.
+
+  * Upgrade to 1.4.0 (udev/udev-configure-printer.c to match cups 1.6 
+    API).
+
+ -- Alban Browaeys <pra...@yahoo.com>  Mon, 08 Apr 2013 08:25:11 +0200
+
 system-config-printer (1.3.7-4) unstable; urgency=low
 
   * debian/control.in: Add missing Depends against python-dbus
diff -Nru system-config-printer-1.3.7/debian/install system-config-printer-1.4.0/debian/install
--- system-config-printer-1.3.7/debian/install	2011-12-13 20:17:22.000000000 +0100
+++ system-config-printer-1.4.0/debian/install	2013-04-08 07:54:29.000000000 +0200
@@ -1,8 +1,10 @@
 debian/tmp/etc/xdg/
 debian/tmp/etc/dbus-1/
+debian/tmp/usr/share/dbus-1/
 debian/tmp/usr/share/applications
 debian/tmp/usr/share/locale
 debian/tmp/usr/share/man
 debian/tmp/usr/share/system-config-printer/system-config-printer.py /usr/bin
+debian/tmp/usr/bin/scp-dbus-service
 debian/tmp/usr/share/system-config-printer/*/
 debian/gpk-install-package-name /usr/share/system-config-printer/
diff -Nru system-config-printer-1.3.7/debian/patches/0001-Adjust-python-paths.patch system-config-printer-1.4.0/debian/patches/0001-Adjust-python-paths.patch
--- system-config-printer-1.3.7/debian/patches/0001-Adjust-python-paths.patch	2011-12-13 20:55:52.000000000 +0100
+++ system-config-printer-1.4.0/debian/patches/0001-Adjust-python-paths.patch	2013-04-08 08:32:12.000000000 +0200
@@ -7,8 +7,6 @@
  system-config-printer.py |    2 ++
  2 files changed, 3 insertions(+), 0 deletions(-)
 
-diff --git a/applet.py b/applet.py
-index 221291a..61b3a97 100644
 --- a/applet.py
 +++ b/applet.py
 @@ -20,6 +20,7 @@
@@ -19,8 +17,6 @@
  from debug import *
  
  import dbus
-diff --git a/system-config-printer.py b/system-config-printer.py
-index 4b26c07..45fdeb3 100755
 --- a/system-config-printer.py
 +++ b/system-config-printer.py
 @@ -22,6 +22,8 @@
diff -Nru system-config-printer-1.3.7/debian/patches/0002-Disable-firewall-checks.patch system-config-printer-1.4.0/debian/patches/0002-Disable-firewall-checks.patch
--- system-config-printer-1.3.7/debian/patches/0002-Disable-firewall-checks.patch	2011-12-13 20:55:52.000000000 +0100
+++ system-config-printer-1.4.0/debian/patches/0002-Disable-firewall-checks.patch	2013-04-08 08:33:42.000000000 +0200
@@ -6,11 +6,9 @@
  firewall.py |   14 ++------------
  1 files changed, 2 insertions(+), 12 deletions(-)
 
-diff --git a/firewall.py b/firewall.py
-index 94c1fa6..942e225 100644
---- a/firewall.py
-+++ b/firewall.py
-@@ -94,20 +94,10 @@ class Firewall:
+--- a/firewallsettings.py
++++ b/firewallsettings.py
+@@ -222,21 +222,11 @@
              pass
  
      def _check_any_allowed (self, search):
@@ -20,16 +18,17 @@
 -        return len (isect) != 0
 +        return True
  
-     def add_rule (self, rule):
+ 
+     def add_service (self, service):
 -        try:
 -            (args, filename) = self._fw_data
 -        except AttributeError:
 -            (args, filename) = self._get_fw_data ()
 -        if filename == None: return
 -
--        args.append (rule)
+-        args.append ("--service=" + service)
 -        self._fw_data = (args, filename)
 +        pass
  
      def check_ipp_client_allowed (self):
-         return self._check_any_allowed (set(["--port=631:udp",
+         return self._check_any_allowed (set(["--port=%s:%s" %
diff -Nru system-config-printer-1.3.7/debian/patches/0005-Fix-French-translation.patch system-config-printer-1.4.0/debian/patches/0005-Fix-French-translation.patch
--- system-config-printer-1.3.7/debian/patches/0005-Fix-French-translation.patch	2013-01-24 19:28:04.000000000 +0100
+++ system-config-printer-1.4.0/debian/patches/0005-Fix-French-translation.patch	2013-04-14 16:29:58.000000000 +0200
@@ -4,12 +4,12 @@
 
 --- a/po/fr.po
 +++ b/po/fr.po
-@@ -2585,7 +2585,7 @@ msgstr "Impression intelligente"
+@@ -2375,7 +2375,7 @@
  #. Not more than 25 characters
- #: ../ui/PrinterPropertiesDialog.ui.h:59
+ #: ../ui/PrinterPropertiesDialog.ui.h:14
  msgid "Print Self-Test Page"
 -msgstr "Imprimer la page de test"
 +msgstr "Imprimer la page de diagnostic"
  
- #: ../ui/PrinterPropertiesDialog.ui.h:62
- #, fuzzy
+ #. Not more than 25 characters
+ #: ../ui/PrinterPropertiesDialog.ui.h:16
diff -Nru system-config-printer-1.3.7/debian/patches/series system-config-printer-1.4.0/debian/patches/series
--- system-config-printer-1.3.7/debian/patches/series	2013-01-24 11:36:27.000000000 +0100
+++ system-config-printer-1.4.0/debian/patches/series	2013-04-08 08:35:13.000000000 +0200
@@ -1,5 +1,4 @@
 0001-Adjust-python-paths.patch
 0002-Disable-firewall-checks.patch
 0003-Use-our-custom-cpk-install-package-name.patch
-0004-Fix-MITM-via-unencrypted-metadata-download.patch
 0005-Fix-French-translation.patch
diff -Nru system-config-printer-1.3.7/debian/postinst system-config-printer-1.4.0/debian/postinst
--- system-config-printer-1.3.7/debian/postinst	2011-12-13 20:17:22.000000000 +0100
+++ system-config-printer-1.4.0/debian/postinst	2013-04-08 07:55:07.000000000 +0200
@@ -4,6 +4,26 @@
 
 #DEBHELPER#
 
+
+case "$1" in
+    configure)
+        # reload dbus config file
+        if [ -x /etc/init.d/dbus ]; then
+            invoke-rc.d dbus force-reload || true
+        fi
+
+        ;;
+    abort-upgrade|abort-remove|abort-deconfigure)
+    ;;
+
+    *)
+        echo "postinst called with unknown argument \`$1'" >&2
+        exit 0
+    ;;
+esac
+
+
+
 # Remove old configuration file
 if [ "$1" = upgrade ] && dpkg --compare-versions "$2" lt-nl "1.0.0-1"; then
     rm -f /etc/xdg/autostart/redhat-print-applet.desktop
diff -Nru system-config-printer-1.3.7/debian/rules system-config-printer-1.4.0/debian/rules
--- system-config-printer-1.3.7/debian/rules	2011-12-22 20:00:30.000000000 +0100
+++ system-config-printer-1.4.0/debian/rules	2013-04-14 16:47:04.000000000 +0200
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 DEB_PYTHON_SYSTEM = pysupport
-GNOME_DOWNLOAD_URL = http://cyberelk.net/tim/data/system-config-printer/1.3/$(GNOME_TARBALL)
+GNOME_DOWNLOAD_URL = http://cyberelk.net/tim/data/system-config-printer/1.4/$(GNOME_TARBALL)
 TARBALL_EXT := tar.xz
 
 include /usr/share/cdbs/1/rules/debhelper.mk
@@ -17,7 +17,7 @@
 	cp debug.py smburi.py cupshelpers/
 
 cleanbuilddir/python-cupshelpers::
-	rm -rf cupshelpers/options.py cupshelpers/smburi.py
+	rm -rf cupshelpers/debug.py cupshelpers/smburi.py
 
 binary-install/system-config-printer::
 	for i in debian/tmp/usr/share/system-config-printer/*.py; do \

Reply via email to