Alle venerdì 26 aprile 2013, Kartik Mistry ha scritto:
> On Fri, Apr 26, 2013 at 2:05 AM, Pino Toscano <p...@debian.org> wrote:
> > the changes in the experimental version still make xosview compiled
> > as "linux" even in non-Linux OSes, and never uses the right
> > platform string on kFreeBSD.
> > The attached patch factorizes the detection of the platform string
> > to use when invoking make,
> > - making it use the right one on kFreeBSD (which though won't
> > compile
> > 
> >   yet, and that will need proper fixes)
> > 
> > - bailing out when the OS is not recognized, and it is easy (just
> > add
> > 
> >   the two proper lines in that if chain, e.g. starting from the
> >   kfreebsd ones) to add cases for new OSes
> 
> Thanks a lot. I was about to commit my fix in git repo (and also
> realized that kfreebsd build is not yet ready!), but your patch is
> way much better. Committed to git repo. I'll disable kfreebsd-*
> build and upload in a day or two.

Thanks, but why leaving it commented and removing the kfreebsd build?
After all, xosview on kfreebsd has not been compiled before, so having 
it fail is not a regression wrt previous versions (thus it won't stop 
xosview migrating to testing, when uploaded to unstable).
Just leave the platform selection as it is and readd kfreebsd-any as 
architecture for xosview, so kfreebsd porters can notice the build 
failure and possibly provide patches for it.

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to