On Mon, May 13, 2013 at 12:05:58PM -0700, Don Armstrong wrote: > Package: rsync > Severity: minor > Version: 3.0.9-4 > > On Sun, 12 May 2013, Philip Hands wrote: > > The current state of rsyncd is probably my fault (as initial packager > > of rsync). One _could_ have an rsyncd package, containing just a > > commented out example /etc/rsyncd.conf and the init.d script, but I > > don't really see the point. If ...ENABLE=false settings are banned in > > defaults files (as I've come to think they should be) then in the case > > of rsyncd, one could make the running of the daemon conditional on the > > existence of the $RSYNC_CONFIG_FILE file (which is not shipped in the > > package). > > Right. For rsync, I think this is the right setup. If one does not have > a rsyncd.conf, there's no point in starting rsyncd, and if one creates > one, having to also figure out that you need to twiddle > /etc/default/rsync to set RSYNC_ENABLE=true (or stop the daemon if > you've somehow managed to start it) is rather annoying. This would > merely require commenting out the RSYNC_ENABLE in /etc/default/rsync, > and changing RSYNC_ENABLE=false to RSYNC_ENABLE=true in > /etc/init.d/rsync.
I disagree; supplying a valid configuration for a daemon is not the same things as saying that I want to run it at that moment (or the next time the init system decides to start it); this is potentially dangerous action at a distance. For a new package, it would be slightly more tolerable, but I worry that implementing this change of default will result in unwanted rsyncd processes running, quite possibly in a configuration which risks unwanted exposure of data, somewhere, due to people relying (deliberately or not) on the current behaviour. > I don't believe that getting rid of RSYNC_ENABLE completely is > necessary, as it permits someone to configure rsyncd out of inetd. -- Dominic Hargreaves | http://www.larted.org.uk/~dom/ PGP key 5178E2A5 from the.earth.li (keyserver,web,email) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
