On 14.5.2013, at 15.53, Jonathan Dowland <j...@debian.org> wrote:

> Hello,
> 
> On Tue, May 14, 2013 at 01:37:48PM +0300, Timo Sirainen wrote:
>> The maildir filename has wrong S=size value.
> 
> That's strange. the ,S= values were all almost certainly set by dovecot 
> version
> 1:1.2.15-7, so I wonder why they are set incorrectly.

I don't remember any specific Dovecot bugs that caused this, but I guess it's 
possible that nobody just noticed them until now.

>> Dovecot should fix this automatically, but since it does it only one failure
>> at a time it can take a while..
> 
> Indeed, I'd suggest that the current behaviour (fix one file, then break the
> IMAP connection) is a bug. It seems the open() logic is not aware that the
> filename has been changed.

The problem is that IMAP client needs to be disconnected after noticing this 
error. I guess it would be possible for Dovecot to just rescan all of the mails 
in the mailbox when seeing such an error, but if there really is just one 
message that was broken doing this would be very inefficient.

>> Other solutions would be to either have Dovecot ignore the value with
>> maildir_broken_filename_sizes=yes
> 
> The check is there to protect against truncation/corruption, right? So it
> would probably be best for it to be left on.

This means that when Dovecot wants to know the message size and it's not 
already cached, it uses stat() instead of taking it from the S=size in 
filename. So it makes the performance a tiny bit worse in some situations.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to