Bug#708247: pu: package smcroute/0.95-2

[Micha Lenk]

Hi Ansgar,

Am 14.05.2013 15:35, schrieb Ansgar Burchardt:
> On 05/14/2013 15:16, Micha Lenk wrote:
>>   * Switch to dpkg-source 3.0 (quilt) format for easier patch maintenance.
> 
> I'm not on the release team, but from experience the release team
> doesn't want such changes in stable. Please apply the patch directly.

Even though personally I prefer to manage patches somehow, I am also
fine with applying this single patch directly. See an updated debdiff
output attached to this message.

Regards,
Micha

diff -u smcroute-0.95/debian/changelog smcroute-0.95/debian/changelog
--- smcroute-0.95/debian/changelog
+++ smcroute-0.95/debian/changelog
@@ -1,3 +1,10 @@
+smcroute (0.95-2) stable; urgency=low
+
+  * Fix a NULL pointer dereferencing in interface vector initialization
+    (closes: #707793, LP: #1043688).
+
+ -- Micha Lenk <mi...@debian.org>  Tue, 14 May 2013 15:59:20 +0200
+
 smcroute (0.95-1) unstable; urgency=low
 
   * New upstream version, added support for FreeBSD
only in patch2:
unchanged:
--- smcroute-0.95.orig/src/ifvc.c
+++ smcroute-0.95/src/ifvc.c
@@ -50,12 +50,13 @@
   }
 
   for (ifa = ifaddr; ifa != NULL; ifa = ifa->ifa_next) {
+    /* Skip interface without internet address */
+    if (ifa->ifa_addr == NULL) continue;
+
     int family = ifa->ifa_addr->sa_family;
 
     /* Skip non-IPv4 and non-IPv6 interfaces */
     if ((family != AF_INET) && (family != AF_INET6)) continue;
-    /* Skip interface without internet address */
-    if (ifa->ifa_addr == NULL) continue;
 
     /* Copy data from interface iterator 'ifa' */
     strncpy(IfDescEp->Name, ifa->ifa_name, sizeof(IfDescEp->Name));