On Wed, May 15, 2013 at 8:25 AM, Jakub Wilk <jw...@debian.org> wrote:
> * Andrew Starr-Bochicchio <a...@debian.org>, 2013-05-12, 18:00:
>
>> Upstream supports building python3 bindings. It would be nice to have
>> those in Debian.
>
>
> I'm not the maintainer, but here's my review:
>
>> +Provides: ${python3:Provides}
>
>
> I've been advocating against python Provides:
> http://lists.debian.org/20110324164804.ga5...@jwilk.net
>
>> +Breaks: ${python3:Breaks}
>
>
> dh_python3 doesn't generate ${python:Breaks}.
>
>> +usr/lib/python3*/*-packages/*[!d]m{,u}.so
>> +usr/lib/python3*/*-packages/*.egg-info
>
>
> Lintian should have emitted brace-expansion-in-debhelper-config-file here.
> (I'm not sure why it didn't. I'll file a bug about it later.)

Thanks for the review Jakub! Updated patch should address your points.

-- Andrew Starr-Bochicchio

   Ubuntu Developer <https://launchpad.net/~andrewsomething>
   Debian Developer <http://qa.debian.org/developer.php?login=asb>
   PGP/GPG Key ID: D53FDCB1

Attachment: 0001-Build-python3-packages.patch
Description: Binary data

Reply via email to