retitle 708593 libcdk-perl: FTBFS with perl 5.18 / ExtUtils::ParseXS 3.18: typos in Cdk.xs tag 708593 patch thanks
On Fri, May 17, 2013 at 12:09:27AM +0100, Dominic Hargreaves wrote: > Source: libcdk-perl > Version: 20120324-1 > Severity: important > User: [email protected] > Usertags: perl-5.18-transition > > This package FTBFS with perl 5.18 from experimental (in a clean sbuild > session): This is caused by a few cut and paste errors/typos in Cdk.xs that ExtUtils::ParseXS 3.18 detects better than earlier versions. Patch attached. -- Niko Tyni [email protected]
>From 1a9b3a0f61059daaa40b3a1819ac75c4a52d7565 Mon Sep 17 00:00:00 2001 From: Niko Tyni <[email protected]> Date: Sat, 18 May 2013 13:20:10 +0300 Subject: [PATCH] Fix a few parameter typos caught be newer versions of ExtUtils::ParseXS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ExtUtils::ParseXS 3.18 (bundled with Perl 5.18) makes the build fail due to a few apparent cut-and-paste errors. Cdk.c: In function ‘XS_Cdk__Menu_Draw’: Cdk.c:5244:2: error: too few arguments to function ‘sv2int’ Cdk.xs:718:1: note: declared here Cdk.c: In function ‘XS_Cdk__Alphalist_SetFillerChar’: Cdk.c:16542:2: error: too few arguments to function ‘sv2chtype’ Cdk.xs:341:1: note: declared here Cdk.c: In function ‘XS_Cdk__Alphalist_SetHighlight’: Cdk.c:16571:2: error: too few arguments to function ‘sv2chtype’ Cdk.xs:341:1: note: declared here --- Cdk.xs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Cdk.xs b/Cdk.xs index cd31557..9d9cc7e 100644 --- a/Cdk.xs +++ b/Cdk.xs @@ -2434,7 +2434,7 @@ PostProcess(object,functionRef) RETVAL void -Draw(object) +Draw(object, Box) CDKMENU * object int Box = sv2int ($arg); CODE: @@ -6585,7 +6585,7 @@ SetContents(object,list) } void -SetFillerChar(object,fille) +SetFillerChar(object,filler) CDKALPHALIST* object chtype filler = sv2chtype ($arg); CODE: @@ -6596,10 +6596,10 @@ SetFillerChar(object,fille) void SetHighlight(object,highlight) CDKALPHALIST* object - chtype filler = sv2chtype ($arg); + chtype highlight = sv2chtype ($arg); CODE: { - setCDKAlphalistHighlight (object,filler); + setCDKAlphalistHighlight (object,highlight); } void -- 1.7.10.4
