Control: tags -1 + patch

On 2013-05-09 10:12:31, Lucas Nussbaum wrote:
> Source: phoneuid
> Version: 0.1+git20110506-2
> Severity: serious
> Tags: jessie sid
> User: debian...@lists.debian.org
> Usertags: qa-ftbfs-20130509 qa-ftbfs
> Justification: FTBFS on amd64
> 
> Hi,
> 
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
> 
> Relevant part:
> > gcc -DHAVE_CONFIG_H -I. -I..    -Wall -Wextra -Werror -Wno-strict-aliasing 
> > -DDATADIR=\"/usr/share\" -DPKGDATADIR=\"/usr/share/phoneuid\" 
> > -DG_LOG_DOMAIN=\"phoneuid\" -pthread -I/usr/include/glib-2.0 
> > -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/shr-glib 
> > -pthread -I/usr/include/phoneui -I/usr/include/glib-2.0 
> > -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/fso-glib 
> > -I/usr/include/fsoframework-2.0 -I/usr/include/libnl3 -ggdb -g -O2 -c -o 
> > phoneuid-phoneuid.o `test -f 'phoneuid.c' || echo './'`phoneuid.c
> > phoneuid.c: In function 'main':
> > phoneuid.c:167:2: error: 'g_type_init' is deprecated (declared at 
> > /usr/include/glib-2.0/gobject/gtype.h:669) [-Werror=deprecated-declarations]
> > phoneuid.c:170:3: error: 'g_thread_init' is deprecated (declared at 
> > /usr/include/glib-2.0/glib/deprecated/gthread.h:260) 
> > [-Werror=deprecated-declarations]
> > cc1: all warnings being treated as errors
> > make[3]: *** [phoneuid-phoneuid.o] Error 1

The attached patch fixes this error. There appears to be a libfso-glib1
-> libfso-glib2 and some of phoneuid's dependencies haven't been
rebuilt, so I won't NMU until the dependencies have been rebuilt against
libfso-glib2.

Regards
-- 
Sebastian Ramacher
diff -Nru phoneuid-0.1+git20110506/debian/changelog phoneuid-0.1+git20110506/debian/changelog
--- phoneuid-0.1+git20110506/debian/changelog	2012-05-11 15:53:47.000000000 +0200
+++ phoneuid-0.1+git20110506/debian/changelog	2013-05-21 13:20:27.000000000 +0200
@@ -1,3 +1,11 @@
+phoneuid (0.1+git20110506-2.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * debian/patches/glib.patch: Don't call deprecated glib functions. (Closes:
+    #707421)
+
+ -- Sebastian Ramacher <sramac...@debian.org>  Tue, 21 May 2013 13:20:26 +0200
+
 phoneuid (0.1+git20110506-2) unstable; urgency=low
 
   * update debian/copyright to use copyright format 1.0
diff -Nru phoneuid-0.1+git20110506/debian/patches/glib.patch phoneuid-0.1+git20110506/debian/patches/glib.patch
--- phoneuid-0.1+git20110506/debian/patches/glib.patch	1970-01-01 01:00:00.000000000 +0100
+++ phoneuid-0.1+git20110506/debian/patches/glib.patch	2013-05-21 13:20:06.000000000 +0200
@@ -0,0 +1,19 @@
+Description: Don't call deprecated glib functions
+Author: Sebastian Ramacher <sramac...@debian.org>
+Last-Update: 2013-05-21
+
+--- phoneuid-0.1+git20110506.orig/src/phoneuid.c
++++ phoneuid-0.1+git20110506/src/phoneuid.c
+@@ -164,10 +164,12 @@ main(int argc, char **argv)
+ 	g_log_set_fatal_mask(NULL, G_LOG_LEVEL_ERROR);
+ 	g_log_set_default_handler(_log_handler, NULL);
+ 	_load_config();
++#if !GLIB_CHECK_VERSION(2,35,0)
+ 	g_type_init();
+ 
+ 	if (!g_thread_supported())
+ 		g_thread_init(NULL);
++#endif
+ 
+ 	phoneui_load("phoneuid");
+ 	phoneui_init(argc, argv, NULL);
diff -Nru phoneuid-0.1+git20110506/debian/patches/series phoneuid-0.1+git20110506/debian/patches/series
--- phoneuid-0.1+git20110506/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ phoneuid-0.1+git20110506/debian/patches/series	2013-05-21 13:16:31.000000000 +0200
@@ -0,0 +1 @@
+glib.patch

Attachment: signature.asc
Description: Digital signature

Reply via email to