Package: ipppd
Version: 1:3.25+dfsg1-3+nmu2
Severity: serious
Tags: patch
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy ...

But the more serious bug is this link being created in the first place
due to a bug in the postinst script:

0m29.1s ERROR: FAIL: Package purging left files on system:
  /isdnctrl -> isdnctrl0         not owned


I'm attaching a patch that fixes the link creation and cleans up the
misplaced one.
I intend to NMU isdnutils to unstable and get this fix into
wheezy-proposed-updates.
I'd prefer not to merge any other of the changes currently in
experimental into unstable at this time to give the fix that is intended
for stable a bit of testing in unstable first.


Andreas

Attachment: ipppd_1:3.25+dfsg1-3+nmu2.log.gz
Description: GNU Zip compressed data

diff --git a/debian/changelog b/debian/changelog
index 3a2ef6d..4323b88 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+isdnutils (1:3.25+dfsg1-3.3) UNRELEASED; urgency=low
+
+  [ Andreas Beckmann ]
+  * Non-maintainer upload.
+  * ipppd.postinst: Create isdnctrl symlink as /dev/isdnctrl and cleanup
+    possibly misplaced symlink /isdnctrl.  (Closes: #xxxxxx)
+
+  [ Christoph Biedl ]
+  * unbreak debian/{ipppd,isdnlog}.config once more. Closes: #696660
+
+ -- Andreas Beckmann <a...@debian.org>  Sat, 01 Jun 2013 20:15:30 +0200
+
 isdnutils (1:3.25+dfsg1-3+nmu2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff --git a/debian/gbp.conf b/debian/gbp.conf
new file mode 100644
index 0000000..0bb78a0
--- /dev/null
+++ b/debian/gbp.conf
@@ -0,0 +1,3 @@
+[DEFAULT]
+debian-branch = wheezy
+upstream-branch = dfsg
diff --git a/debian/ipppd.config b/debian/ipppd.config
index 33d9ae9..9d9fd50 100644
--- a/debian/ipppd.config
+++ b/debian/ipppd.config
@@ -37,6 +37,7 @@ if [ -s "/etc/isdn/device.$ipppd_if" -o -s "/etc/isdn/ipppd.$ipppd_if" ]; then
 fi
 
 db_input high ipppd/ispphone || true
+status=0
 db_go || status=$?
 if [ $status -eq 30 ]; then
         db_stop
diff --git a/debian/ipppd.postinst b/debian/ipppd.postinst
index ccf442d..2702edb 100644
--- a/debian/ipppd.postinst
+++ b/debian/ipppd.postinst
@@ -27,8 +27,12 @@ case "$1" in
 	fi
 	# FIXME BUG! MAKEDEV should create the link by itself
 	if [ ! -d /dev/.udev/ ] && [ ! -d /run/udev ] ; then
-	    rm -f isdnctrl
-	    ln -s isdnctrl0 isdnctrl
+	    rm -f /dev/isdnctrl
+	    ln -s isdnctrl0 /dev/isdnctrl
+	fi
+	if [ -L /isdnctrl ]; then
+	    # Cleanup possibly misplaced symlink created by 1:3.25+dfsg1-3+nmu2
+	    rm /isdnctrl
 	fi
 	cd "$old_pwd"
         forcerestart=false
diff --git a/debian/isdnlog.config b/debian/isdnlog.config
index 938a6da..68ef9a7 100644
--- a/debian/isdnlog.config
+++ b/debian/isdnlog.config
@@ -36,6 +36,7 @@ if [ -s /etc/isdn/isdn.conf ]; then
     fi
 fi
 db_input high isdnlog/country || true
+status=0
 db_go || status=$?
 if [ $status -eq 30 ]; then
 	exit 1	# cancel selected

Reply via email to