On Wed, Jun 05, 2013 at 11:42:19PM +0200, Benjamin Drung wrote: > Am Mittwoch, den 05.06.2013, 15:15 -0400 schrieb Daniel Kahn Gillmor: > > [i'm not on the devscripts-devel list, please cc me or > > 610...@bugs.debian.org] > > > > On Sat 2013-05-04 05:26:55 -0400, Daniel Kahn Gillmor wrote: > > > > > On Sat 2013-05-04 05:03:36 -0400, Daniel Kahn Gillmor wrote: > > > > > >> The attached patch implements the above proposal, using (e.g.) > > >> opts=pgpsigurlmangle=s/$/.asc/ and debian/upstream-signing-key.pgp. > > > > > > This time with the patch actually attached :/ > > > > Any thoughts on this patch? > > I took a quick look at the patch and found to things: 1) Please update > README in addition to d/control and 2) please check the indentation.
A little clarification on this. uscan uses (as most of the shell/Perl scripts in devscripts do) the following indent style: - Each indent level is 4 columns - Use tabs when the indent is a multiple of 8 - Use spaces for the rest There are some hunks in your patch that should be updated accordingly. > > As a DD, I'm a member of collab-maint -- > > should i just go ahead and commit it to the devscripts repo? It works > > for me, and i would like to start using it for debian packages that have > > an upstream that signs releases. > > I vote for "go ahead". Welcome in the devscripts devel team! Agreed. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <james...@debian.org>
signature.asc
Description: Digital signature