Package: thinkfan
Version: 0.8.1-1
Severity: normal
Tags: patch

Currently, the thinkfan.service file contains a broken ExecReload line.

The attached patch fixes it, please apply it for your next upload. I
also forwarded the issue upstream and reflected that in the patch.

Thanks.
>From 61d1782ef7957da75f918e534e5c078cd4924d9d Mon Sep 17 00:00:00 2001
From: Michael Stapelberg <mich...@stapelberg.de>
Date: Sun, 23 Jun 2013 15:14:42 +0200
Subject: [PATCH 1/2] bugfix: use $MAINPID for ExecReload

---
 debian/patches/bashism.patch |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/debian/patches/bashism.patch b/debian/patches/bashism.patch
index e5b2e8e..cb2491e 100644
--- a/debian/patches/bashism.patch
+++ b/debian/patches/bashism.patch
@@ -1,6 +1,7 @@
-From: Evgeni Golov <evg...@debian.org>
-Subject: do not use $(< ...), it's a bashism. use $(cat ...) instead
-Last-Update: 2012-06-06
+From: Michael Stapelberg <stapelb...@debian.org>
+Subject: do not use $(< ...), it's a bashism. use $MAINPID instead
+Last-Update: 2013-06-23
+Forwarded: https://sourceforge.net/p/thinkfan/thinkfan-bugs/11/
 
 diff --git a/rcscripts/thinkfan.service b/rcscripts/thinkfan.service
 index d642262..c9434ca 100644
@@ -11,7 +12,7 @@ index d642262..c9434ca 100644
  ExecStart=/usr/sbin/thinkfan
  PIDFile=/var/run/thinkfan.pid
 -ExecReload=/bin/kill -HUP $(</var/run/thinkfan.pid)
-+ExecReload=/bin/kill -HUP $(cat /var/run/thinkfan.pid)
++ExecReload=/bin/kill -HUP $MAINPID
  
  [Install]
  WantedBy=multi-user.target
-- 
1.7.10.4

Reply via email to