On Sun, Jun 30, 2013 at 12:29:57PM -0400, David Prévot wrote: [...] > FYI, I just uploaded a similar php-symfony-eventdispatcher taking into > account the previous remarks. > > http://anonscm.debian.org/gitweb/?p=pkg-php/php-symfony-eventdispatcher.git
thanks, this was very useful, especially for examples of overrides in debian/rules. i have pushed my changes, taking your feedback into account, to http://anonscm.debian.org/gitweb/?p=pkg-php/php-symfony-process.git;a=summary On Sat, Jun 29, 2013 at 09:13:21PM -0400, David Prévot wrote: [..] > Here are some early thoughts after a quick overview of your package. > > On top of the s/2// already in discussion, please update debian/compat. > > What is the use of the explicit “Build-Depends-Indep: php-pear” in > debian/control? i was wondering myself :) it was generated by debpear and i was hit by a sudden headeache when trying to understand the Build-Depends-Indep field's purpose from the new maintainer's guide... :) i have now updated these based on your example. > What is the use of override_dh_auto_configure, override_dh_auto_clean, > and override_dh_auto_build in debian/rules? legacy of an attempt to add a meta-package before discussing the symfony/symfony2 issue in package names - removed now. however, override_dh_auto_configure was taken from what i was previously using as an example (http://anonscm.debian.org/gitweb/?p=pkg-php/php-symfony2-yaml.git;a=blob;f=debian/rules;h=9a0185a4de308d6d6545464cbaaa9aa2778cee73;hb=HEAD) and relates to my question below re package.xml contents: not sure if this is useful/needed. > Not sure it’s useful to enforce gbp default values (upstream-tag and > pristine-tar). you're right. i have only left upstream-tag since upstream use vX.Y.Z whereas the default (at least in my local git-buildpackage=0.6.0~git20130530) is in the X.Y.Z form. thanks. > debian/watch shouldn’t miss the beta and RC. thanks, updated. > Please, drop the tests from the binary package, as well as > phpunit.xml.dist, composer.json, CHANGELOG.md and the misplaced > README.md (hint: you can compare the the two binary packages, the > Composer and the PEAR one, to notice the differences). thanks, updated as well. the package.xml file is packaged intact so it does actually contain XML elements for the removed files under Test - is this ok? and finally, this package could be useful on CLI-only systems, however when built as a composer package as in my first attempt, substvars made it depend on php5 | php5-cli, whereas when building it as a PEAR package, substvars make it depend on php5 only: short of adding this by hand in debian/control, am i using substvars in a wrong way or is this enforced by the phppear build system? i think it would be ok for these components to depend on either, for use on systems without the full php5 meta-package installed. thanks andrea -- andrea rota Xelera - IT infrastructures http://xelera.eu/contact-us/
signature.asc
Description: Digital signature