Hi Colin, On 08.07.2013 16:26, Colin Watson wrote: > I think that this patch should do the job, but it's the first module > I've worked on for the 2.4 transition. Could a Debian Apache expert > have a look? If it looks OK, I'm willing to NMU for this, since the > last maintainer upload was nearly six years ago.
sure. Your patch looks fine and does the packaging side of the module
exactly the way it's meant.
> -Build-Depends: debhelper (>= 4.0.0), libiconv-hook-dev, apache2-threaded-dev
> (>= 2.0.50-9) | apache2-dev (>= 2.0.50-9)
> +Build-Depends: debhelper (>= 4.0.0), libiconv-hook-dev, dh-apache2,
> apache2-dev (>= 2.0.50-9)
This is all fine, though (>= 2.0.50-9) is trivially satisfied for eons
in Debian. You may keep it as is, but any version of Apache provided in
Debian since Sarge (I think) satisfies this dependency.
> -Depends: apache2.2-common, ${shlibs:Depends}
> +Depends: ${shlibs:Depends}, ${misc:Depends}
Perfect. That's the most important part of the whole transition. That
said, I never tested dh-apache2 at such low compat levels. Please ensure
it works correctly and adds apache2-api-20120211 to ${misc:Depends}.
Everything else looks correct, too. Please note, I did not compile the
module with your patch. Please pay attention whether the upstream
codebase still compiles against the 2.4 APIs. In particular the build
system is often not triggering a fatal build failure for obsolete
symbols due to the nature of a plugin. However, may test rebuild last
year [1] indicated it would still work indeed.
Apart, please go ahead an NMU the module as soon as you see it fits to you.
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=666842#10
--
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
signature.asc
Description: OpenPGP digital signature
