Package: golang
Version: 2:1.1.1-3
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu saucy ubuntu-patch

Downstream bug: https://launchpad.net/bugs/1200255

golang binaries crash on some architectures if they are stripped during
packaging. Upstream are aware of this, but do not currently support the
stripping of binaries.

Dave Cheney says:

        * not supported, as in, we don't support it, and recommend against
          it when asked
        * not tested, we don't test stripped binaries as part of the build
          CI process
        * is often broken, stripping a go binary will produce anywhere
          from no, to subtle, to outright execution failure, see above
        * doesn't do what you want, we have a flag called -g, but the
          information it stores in the elf sections is a superset of what
          strip thinks it is removing, in short, strip does not strip out
          the debug data, we hide it too well.


        To clarify my previous statements.

        * I do not disagree with the debian policy, it is there for a good
          reason
        * Having said that, it stripping Go binaries doesn't work, and
          nobody is looking at making it work, so there is that.

        Thanks for patching the build formula.

Debian policy says that binaries "should" be stripped, not "must" be
stripped, so I assumed that policy permits this, and that applying the
following patch would be the pragmatic thing to do for Ubuntu. I think
that doing anything else would be considerable effort. Please consider
the same for Debian.

diff -Nru golang-1.1.1/debian/rules golang-1.1.1/debian/rules
--- golang-1.1.1/debian/rules   2013-07-11 14:13:41.000000000 -0400
+++ golang-1.1.1/debian/rules   2013-07-16 08:19:46.000000000 -0400
@@ -95,7 +95,8 @@
        find $(CURDIR)/debian/golang-go/usr/lib/go/pkg -exec touch -r 
$(CURDIR)/debian/golang-go/usr/lib/go/pkg {} \;
 
 override_dh_strip:
-       dh_strip -X".a" -Xgoinstall -Xgodoc -Xgoyacc -Xbin/cgo -Xebnflint 
-Xgofix -Xgofmt -Xgovet -Xgotest --dbg-package=$(PACKAGE)-dbg
+       # strip disabled as golang upstream doesn't support it and it makes go
+       # crash. See https://launchpad.net/bugs/1200255.
 
 override_dh_prep:
        dh_prep


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to