On 04/07/2012 12:52 AM, Sandro Tosi wrote:
> Hello Jörn,
> thanks for looking into this!
>
> I'm also forwarding your results on gkrellm mailing list, so upstream
> authors can have a look at your patch and comment/commit it.
>
> Dear gkrellm authors, attached is a patch to fix a problem with
> battery level upon suspension; you can also have a look at the full
> bug history to get a better idea of how Jörn reached to this patch:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=630117
>
sorry for the extra-late reply. I'd like to incorporate the patch and
according to what I read the new approach of always trying all the
possible sysfs files makes sense, however I have no laptop running Linux
to try the patch out myself.
If anybody else on this list could try the patch to verify it on other
machines that would be great.
Here are a few notes about the actual diff, depending on when and how we
get that change applied either me or somebody else could work on them
(read: I won't reject the patch just because of this nagging, this is
not the Linux kernel):
- VARIANTS could be replaced by an enum for the four variants. That way
setup of the arrays in setup_sysfs_battery would be a bit more
descriptive. The hardcoded indices inside the code and the VARIANTS
define could get out of sync easily if somebody has to touch that code
again. I thought about something along the lines of:
typedef enum SysChargeVariants_ { SCVEnergy, SCVEnergyDesign, SCVCharge,
SCVChargeDesign, SCVCapacity, SCVCount } SysChargeVariants;
- The patch drops all debug output in setup_sysfs_battery(). I think the
output should be ported to at least log the stored paths for the
multiple variants.
Regards,
Stefan Gehn
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
