Control: tags -1 - patch
Control: tags -1 + wontfix
Hi!
On Fri, 2013-08-16 at 09:44:15 +0200, Jérémy Bobbio wrote:
> Package: dpkg
> Version: 1.16.10
> Severity: wishlist
> Tags: patch
> We are currently a few folks interested in enabling byte for byte
> reproducible builds of Debian packages [1].
>
> In order to achieve this, we need a way to record the environment that
> was used to do the initial build. We currently think that the right
> place to do so is the `.changes` file.
Sure, there's also another bug report requesting builtin support for
this, the problem is about possible privacy issue, like leaks of user
information.
> We can currently easily add new fields there by using the `XC-`
> construct in `debian/control`. Unfortunately, `dpkg-genchanges`
> does currently not expand all substvars, limiting our abilities to
> experiment.
For experimenting purposes there's already everything you need in
place, no need for patching, something like this would do:
$ dpkg-buildpackage --changes-option="-DBuild-Env=VarA=foo VarB=bar"
> Can you consider applying the following patch that make
> `dpkg-genchanges` behave just like `dpkg-gencontrol`?
>
> diff --git a/scripts/dpkg-genchanges.pl b/scripts/dpkg-genchanges.pl
> index 0b004c7..13cedd6 100755
> --- a/scripts/dpkg-genchanges.pl
> +++ b/scripts/dpkg-genchanges.pl
> @@ -516,4 +516,5 @@ for my $f (keys %remove) {
> delete $fields->{$f};
> }
>
> -$fields->output(\*STDOUT); # Note: no substitution of variables
> +$fields->apply_substvars($substvars);
> +$fields->output(\*STDOUT);
Expanding substvars “might” possibly only make sense for unknown fields,
the rest of the known fields should be deterministic from the source
package itself. And there's multiple fields that must not use them
at all, this includes the Changes field for example, or we'd get
expansions on changelog entries that mention substvars.
So in principle I'll be tagging this wontfix, and probably closing after
a bit, given that the original request can be already fulfilled by other
(nicer) means.
Thanks,
Guillem
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
