Bug#689899: Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)

[gregor herrmann]

Control: severity -1 serious

On Sun, 07 Oct 2012 23:10:36 +0800, Thomas Goirand wrote:

> Package: mgetty
> Version: 1.1.36-1.6
> Severity: serious
> Tags: patch

 
> /var/run may be a temporary filesystem, so any directories or files needed
> /there must be created dynamically at boot time.
> 
> Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
> details.

E: mgetty-fax: dir-or-file-in-var-lock var/lock/fax/
E: mgetty-fax: dir-or-file-in-var-run var/run/mgetty-fax/

This is now in the ftp-master autoreject list, thus no further upload
of mgetty is possible (cf. #719501). Raising the severity.

I'm attaching a proposed patch; reviews welcome.

+  * Fix "Ships a folder in /var/run or /var/lock (Policy Manual section
+    9.3.2)":
+    - don't create the directories in mgetty-fax.dirs
+    - don't change their permissions in mgetty-fax.postinst
+    - they are already created at runtime in mgetty-fax.init.d
+      including setting permissions
+    - remove them in mgetty-fax.postrm during purge
+    (Closes: #689899)


Cheers,
gregor

 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Cat Stevens: Miles From Nowhere

diff -u mgetty-1.1.36/debian/mgetty-fax.postinst mgetty-1.1.36/debian/mgetty-fax.postinst
--- mgetty-1.1.36/debian/mgetty-fax.postinst
+++ mgetty-1.1.36/debian/mgetty-fax.postinst
@@ -54,8 +54,7 @@
 	    dpkg-statoverride --update --add $FAX_USER $FAX_GROUP 4755 /usr/lib/mgetty-fax/faxq-helper;
 	fi
 
-        for i in /var/spool/fax/outgoing /var/log/mgetty/fax \
-	    /var/run/mgetty-fax /var/lock/fax; do
+        for i in /var/spool/fax/outgoing /var/log/mgetty/fax; do
 		if ! dpkg-statoverride --list $i >/dev/null; then
 		    dpkg-statoverride --update --add $FAX_USER root 0755 $i;
 		fi
diff -u mgetty-1.1.36/debian/mgetty-fax.postrm mgetty-1.1.36/debian/mgetty-fax.postrm
--- mgetty-1.1.36/debian/mgetty-fax.postrm
+++ mgetty-1.1.36/debian/mgetty-fax.postrm
@@ -17,6 +17,7 @@
 	rmdir /etc/mgetty || true;
 	rm -f /var/spool/fax/outgoing/faxqueue_done
         rmdir /var/spool/fax/outgoing /var/spool/fax || true;
+        rm -rf /var/lock/fax /var/run/mgetty-fax
 	;;
     *)
 	;;
diff -u mgetty-1.1.36/debian/mgetty-fax.dirs mgetty-1.1.36/debian/mgetty-fax.dirs
--- mgetty-1.1.36/debian/mgetty-fax.dirs
+++ mgetty-1.1.36/debian/mgetty-fax.dirs
@@ -9,3 +9 @@
-var/lock/fax
 var/log/mgetty/fax
-var/run/mgetty-fax

signature.asc
Description: Digital signature