Bug#721694: Wrong FLAGS order in qmake.pm?

[Joey Hess]

Jaromír Mikeš wrote:
> qmake.pm passing CPPFLAGS after CFLAGS or CXXFLAGS
> 
> --------------------------
>       if ($ENV{CFLAGS}) {
>               push @flags, "QMAKE_CFLAGS_RELEASE=$ENV{CFLAGS} $ENV{CPPFLAGS}";
>               push @flags, "QMAKE_CFLAGS_DEBUG=$ENV{CFLAGS} $ENV{CPPFLAGS}";
>       }
>       if ($ENV{CXXFLAGS}) {
>               push @flags, "QMAKE_CXXFLAGS_RELEASE=$ENV{CXXFLAGS} 
> $ENV{CPPFLAGS}";
>               push @flags, "QMAKE_CXXFLAGS_DEBUG=$ENV{CXXFLAGS} 
> $ENV{CPPFLAGS}";
> ------------------------
> 
> I am not sure, but shouldn't be CPPFLAGS passed before CFLAGS or CXXFLAGS?
> 
> http://www.gnu.org/software/make/manual/html_node/Catalogue-of-Rules.html

This would only matter if CFLAGS were used to override something set in
CPPFLAGS. But CPPFLAGS is flags for cpp, while the others are flags for
cc or c++.

-- 
see shy jo

signature.asc
Description: Digital signature