Please find, for review, the debconf templates and packages descriptions for 
the apt-listdifferences source package.

This review will last from Saturday, September 14, 2013 to Tuesday, September 
24, 2013.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- apt-listdifferences.old/debian/templates    2013-09-04 07:19:28.449443947 
+0200
+++ apt-listdifferences/debian/templates        2013-09-14 13:11:07.700135155 
+0200
@@ -1,19 +1,19 @@
 Template: apt-listdifferences/initialize
 Type: boolean
 Default: true
-_Description: Would you like to initialize the apt-listdifferences database 
now?
- apt-listdifferences can initialize its database of source packages now.
- Depending on your internet connection, this may take a while, but it will also
+_Description: Initialize the apt-listdifferences database now?
+ The source packages database for apt-listdifferences can be initialized now.
+ Depending on your Internet connection, this may take a while, but it will also
  provide immediate functionality for the tool.
  .
- If you select No, apt-list-differences will instead become functional slowly
+ If you do not choose this option, apt-list-differences will instead become 
functional slowly
  over time as more and more reference source packages get added to its database
  when they are first seen.

Simplify the synopsis by dropping "would you like".

Avoid leading lowercase in a sentence by reverting the sentence.


Avoid making reference to specific debconf interfaces (If you select No).

 
 Template: apt-listdifferences/purge
 Type: boolean
 Default: false
-_Description: Would you like to remove the apt-listdifferences database?
- The apt-listdifferences database is currently still on disk.  You can save
+_Description: Remove the apt-listdifferences database?
+ The apt-listdifferences database is currently still present on disk.  You can 
save
  a lot of space by removing it now, but if you ever plan to reinstall
  apt-listdifferences, the database will need to be fully downloaded again.
--- apt-listdifferences.old/debian/control      2013-09-04 07:19:28.449443947 
+0200
+++ apt-listdifferences/debian/control  2013-09-14 13:11:40.089031853 +0200


About the same rationale

@@ -22,6 +22,6 @@
  python-debian,
  debian-keyring,
 Description: source differences notification tool
- apt-listdifferences will show the differences, or patch, between the sources
+ apt-listdifferences will show the differences, or patches, between the sources
  for all packages as they get updated.  This makes it possible to easily
- review source changes that have been included in new Debian package updates.
+ review source changes that have been included in new package updates.


Here, I left the leading lowercasse mostly because I didn't find
anything not too clumsy to replace it

Avoid branding ("Debian").


Template: apt-listdifferences/initialize
Type: boolean
Default: true
_Description: Initialize the apt-listdifferences database now?
 The source packages database for apt-listdifferences can be initialized now.
 Depending on your Internet connection, this may take a while, but it will also
 provide immediate functionality for the tool.
 .
 If you do not choose this option, apt-list-differences will instead become 
functional slowly
 over time as more and more reference source packages get added to its database
 when they are first seen.

Template: apt-listdifferences/purge
Type: boolean
Default: false
_Description: Remove the apt-listdifferences database?
 The apt-listdifferences database is currently still present on disk.  You can 
save
 a lot of space by removing it now, but if you ever plan to reinstall
 apt-listdifferences, the database will need to be fully downloaded again.
--- apt-listdifferences.old/debian/templates    2013-09-04 07:19:28.449443947 
+0200
+++ apt-listdifferences/debian/templates        2013-09-14 13:11:07.700135155 
+0200
@@ -1,19 +1,19 @@
 Template: apt-listdifferences/initialize
 Type: boolean
 Default: true
-_Description: Would you like to initialize the apt-listdifferences database 
now?
- apt-listdifferences can initialize its database of source packages now.
- Depending on your internet connection, this may take a while, but it will also
+_Description: Initialize the apt-listdifferences database now?
+ The source packages database for apt-listdifferences can be initialized now.
+ Depending on your Internet connection, this may take a while, but it will also
  provide immediate functionality for the tool.
  .
- If you select No, apt-list-differences will instead become functional slowly
+ If you do not choose this option, apt-list-differences will instead become 
functional slowly
  over time as more and more reference source packages get added to its database
  when they are first seen.
 
 Template: apt-listdifferences/purge
 Type: boolean
 Default: false
-_Description: Would you like to remove the apt-listdifferences database?
- The apt-listdifferences database is currently still on disk.  You can save
+_Description: Remove the apt-listdifferences database?
+ The apt-listdifferences database is currently still present on disk.  You can 
save
  a lot of space by removing it now, but if you ever plan to reinstall
  apt-listdifferences, the database will need to be fully downloaded again.
--- apt-listdifferences.old/debian/control      2013-09-04 07:19:28.449443947 
+0200
+++ apt-listdifferences/debian/control  2013-09-14 13:11:40.089031853 +0200
@@ -22,6 +22,6 @@
  python-debian,
  debian-keyring,
 Description: source differences notification tool
- apt-listdifferences will show the differences, or patch, between the sources
+ apt-listdifferences will show the differences, or patches, between the sources
  for all packages as they get updated.  This makes it possible to easily
- review source changes that have been included in new Debian package updates.
+ review source changes that have been included in new package updates.
Source: apt-listdifferences
Section: utils
Priority: extra
Maintainer: Michael Gilbert <mgilb...@debian.org>
Build-Depends:
 debhelper (>= 9),
 po-debconf,
 colordiff,
 python3,
 patch,
Built-Using:
 colordiff,
Standards-Version: 3.9.4

Package: apt-listdifferences
Architecture: all
Depends:
 ${misc:Depends},
 ${python3:Depends},
 devscripts,
 python-apt,
 python-debian,
 debian-keyring,
Description: source differences notification tool
 apt-listdifferences will show the differences, or patches, between the sources
 for all packages as they get updated.  This makes it possible to easily
 review source changes that have been included in new package updates.

Attachment: signature.asc
Description: Digital signature

Reply via email to